383473 - exit from _XIOError when using a large font-size-adjust value

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mats Palmgren (inactive)]

Attachment: Testcase - WARNING IT MIGHT CRASH YOUR BROWSER OR X SERVER

exit from _XIOError when using a large font-size-adjust value.

The clamping in bug 348462 is not enough, we need to clamp the final
font size after font-size-adjust have been applied.

Comment 1

[Mats Palmgren (inactive)]

Attachment: stack

Comment 2

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 267448 [details] [diff] [review]
Patch rev. 1

Ugh, I was afraid of that.

The gfx/src/windows change is unnecessary -- nothing calls that (and it probably won't even compile, FONT_MAX_SIZE isn't efined there)

However, for the other stuff, can you add a helper method on gfxFontStyle that you can pass an aspect gfxFloat, that'll return the adjusted size?  style->GetAdjustedSize(aspect) or something, that'll do the clamping in one place?

That way we don't have to duplicate a bunch of this code all over the place and can instead just do mAdjustedSize = GetStyle->GetAdjustedSize(...)

Comment 4

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Regarding the NS_round/ROUND difference: since this is a once per font
calculation I think we can live with the redundant > 0 check that
NS_round has in this case...

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 267619 [details] [diff] [review]
Patch rev. 2

Looks good, thanks!

Comment 6

[Mats Palmgren (inactive)]

Checked in to trunk at 2007-06-08 01:22 PDT.

-> FIXED

Comment 7

[Jesse Ruderman]

Crashtest checked in.