383476 - Cookie display in "show cookies" uses light grey background even with white text.

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Brian Harvey]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3

I have my colors set to white on black.  In the "show cookies" window,
the list of cookies respects this, but the individual cookie contents are
displayed in unreadable white on light grey, even though I unchecked
"allow web pages to use their own colors."

Reproducible: Always

Steps to Reproduce:
1. Set colors to white text on black background.
2. Tools>Options>Privacy>Show Cookies.
3. Select any cookie.
Actual Results:  
Cookie components are shown in white on almost-white grey.

Expected Results:  
White on black.

Comment 1

[Adam Guthrie]

Probably need some -moz-DialogText lovin' around here: http://mxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/preferences/preferences.css#179.

Comment 2

[Adam Guthrie]

Attachment: patch

So this kills the different-colored background on the non-selectable grid on the left of the box. I don't know how we can hard-code a color on it and still be high-contrast friendly.

Comment 3

[Adam Guthrie]

Attachment: before (left) and after (right)

Comment 6

[[e-mail]]

bug also applies to branch, per bug 403927.

Comment 9

[Gravis]

it's been the better part of a year, why isnt the patch in the release yet?  i mean, come on, this is slower than microsoft patches internet explorer!

Comment 10

[[e-mail]]

suggest asking mano or gavin for review here.

Comment 11

[Gravis]

then what the hell is the point of this bug tracker if bugs dont get fixed here?!

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Attachment: updated patch

Updated to current trunk. No need to explicitly specify dialog colors on the box, as far as I can tell - they're the default. Need help testing this on Linux.

Comment 13

[Takeshi Kurosawa :takenspc]

Attachment: Screenshot _without_ patch

Screenshot on Linux/GTK2 (Darklooks theme) without patch.

Comment 14

[Takeshi Kurosawa :takenspc]

Attachment: Screenshot with patch

Screenshot on Linux/GTK2 (Darklooks theme) with patch.
The patch works fine! lol!

Comment 15

[Damon Sicore (:damons)]

Comment on attachment 299717 [details] [diff] [review]
updated patch

a1.9+=damons

Comment 16

[[e-mail]]

Checking in browser/themes/gnomestripe/browser/preferences/preferences.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/preferences.css,v  <--  preferences.css
new revision: 1.27; previous revision: 1.26
done
Checking in browser/themes/winstripe/browser/preferences/preferences.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/preferences.css,v  <--  preferences.css
new revision: 1.23; previous revision: 1.22
done