Closed
Bug 383547
Opened 19 years ago
Closed 19 years ago
Convert font height, ascent, descent and max-advance to integers conservatively
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.98 KB,
patch
|
pavlov
:
review+
|
Details | Diff | Splinter Review |
See discussion in bug 216418. We need nsThebesFontMetrics to convert these values conservatively so that other font metrics converters (i.e. new textframe) don't overflow the metrics reported by nsThebesFontMetrics.
|
Assignee | |
Updated•19 years ago
|
Attachment #267524 -
Flags: review?(pavlov)
|
||
Comment 1•19 years ago
|
||
Comment on attachment 267524 [details] [diff] [review]
fix
+ aHeight = aHeight = CEIL_TO_TWIPS(GetMetrics().maxAscent) +
+ CEIL_TO_TWIPS(GetMetrics().maxDescent);
aHeight = aHeight = ?
Attachment #267524 -
Flags: review?(pavlov) → review+
|
|
Assignee | |
Comment 2•19 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•