mozStorageValueArray only asserts on out of bounds (and other cleanup)

RESOLVED FIXED in mozilla1.9alpha8

Status

()

Toolkit
Storage
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Tracking

Trunk
mozilla1.9alpha8
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

8.44 KB, patch
(not reading, please use seth@sspitzer.org instead)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
I would expect it to return an error code instead of just asserting (not so useful for those on a non-debug build).  A few others agreed, so I'm gonna fix this.
(Assignee)

Comment 1

11 years ago
Created attachment 278512 [details] [diff] [review]
v1.0
Attachment #278512 - Flags: review?(sspitzer)
(Assignee)

Updated

11 years ago
Target Milestone: --- → mozilla1.9 M8
Attachment #278512 - Flags: review?(sspitzer) → review+
(Assignee)

Updated

11 years ago
Attachment #278512 - Flags: approval1.9?
(Assignee)

Comment 2

11 years ago
Comment on attachment 278512 [details] [diff] [review]
v1.0

Toolkit doesn't need approval
Attachment #278512 - Flags: approval1.9?
(Assignee)

Comment 3

11 years ago
Checking in storage/src/mozStorageValueArray.cpp;
new revision: 1.4; previous revision: 1.3
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.