Closed Bug 383673 Opened 15 years ago Closed 14 years ago

mozStorageValueArray only asserts on out of bounds (and other cleanup)

Categories

(Toolkit :: Storage, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Details

Attachments

(1 file)

I would expect it to return an error code instead of just asserting (not so useful for those on a non-debug build).  A few others agreed, so I'm gonna fix this.
Attached patch v1.0Splinter Review
Attachment #278512 - Flags: review?(sspitzer)
Target Milestone: --- → mozilla1.9 M8
Attachment #278512 - Flags: review?(sspitzer) → review+
Attachment #278512 - Flags: approval1.9?
Comment on attachment 278512 [details] [diff] [review]
v1.0

Toolkit doesn't need approval
Attachment #278512 - Flags: approval1.9?
Checking in storage/src/mozStorageValueArray.cpp;
new revision: 1.4; previous revision: 1.3
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.