383763 - Seemingly random crashes in cycle collector code [@ nsCycleCollector::MarkRoots]

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

There's no clear steps to reproduce, the browser will just crash in as I'm browsing, or switching away from the active window. I'll attach an example of a stack that I've seen a couple of times.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: stack

Comment 2

[:Gavin Sharp [email: [e-mail]]]

These crashes started happening to me some time in the past week or so. I don't really have further details, I'll try running a debug build and see if I can debug further.

Comment 3

[(not currently active) Ted Mielczarek]

I'm seeing this on Windows nightly builds, started in the past 3 days or so.  It's frequent enough that using trunk as my daily browser is difficult.  I generally have 3+ tabs open, with gmail, tinderbox, and a few other things open.

Comment 4

[Graydon Hoare :graydon]

This is probably my checkin of the patch for bug 368869. Guess nothing has changed under Igor's new work. I have never been able to reproduce this, but it seems to simply not work. Backing out.

Comment 5

[(not currently active) Ted Mielczarek]

I pulled and built right after this backout, and I've been crash-free since.  I'm still a bit worried since this crash wasn't triggering Breakpad for me on Win32.

Comment 6

[Graydon Hoare :graydon]

Can we close this if nobody's seeing it anymore? I'm pretty sure I caused it.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

I've seen no crashes since you backed out the patch.