383812 - Download manager does not handle ftp downloads well/usually

Status: RESOLVED DUPLICATE of bug 355222

(Toolkit :: Downloads API, defect)

Description

[Rob Arnold [:robarnold]]

Click the link 79d531ww.exe, then hit 'I agree' and make sure ftp is selected, not http. The dialog to save the file will popup (save/cancel), pick save. The file does not appear in download manager nor does it appear to be downloaded. Some other ftp sites do appear to work, but lenovo's appears to fail fairly reliably.

Comment 1

[Shawn Wilsher :sdwilsh]

Can you possibly find a regression range?  (I suggest just before Bug 380250 landed as a starting point)

Comment 2

[Ria Klaassen (not reading all bugmail)]

Regression between 2006-11-05 09 and 2006-11-05 13.
Checkins: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-11-05+08%3A00&maxdate=2006-11-05+14%3A00
I put it on bug 353560.

Comment 4

[(not reading, please use [e-mail] instead)]

fwiw, I am not sure this is limited to ftp:// downloads.

From bug #386990, both the http:// and the ftp:// options have issues.

Comment 5

[(not reading, please use [e-mail] instead)]

As rob and ria have pointed out, this looks like a regression from bug #353560

Comment 6

[Shawn Wilsher :sdwilsh]

has anybody backed out that patch and tried it yet?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

This is basically the same issue as bug 355222, I think. The branch patch that was landed there would probably fix this bug.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Indeed, the patch in bug 355222 fixes this for me, by not closing the download-triggering window and using it as the dialog's parent if it's opener is closed. I'd say this is a straightforward dupe of bug 355222. The only thing that the  patch for bug 353560 did was make the problem more general - we now don't call saveToDisk() at all, because the timeout is on a closed window, whereas we used to only fail if saveToDisk() called promptForSaveToFile() (i.e. if "ask me where to save this file" was true and we tried to init a filepicker with a null parent).