383855 - Use updated word list for spell check

Status: RESOLVED FIXED

(Mozilla Localizations :: nl / Dutch, defect)

Description

[Hendrik Maryns]

Yesterday the word list of OpenTaal has gotten the label of the TaalUnie, such that it is an officially recognised list that has all correct words after the spelling revision of 2005.

The list is available under LGPL, but the makers have assured me that they are willing to change the license in order to make it possible for the list to be used in Mozilla products.

Comment 1

[u81239]

It would be awesome if we could distribute the dictionary with the nl-NL release of Firefox and Thunderbird in future releases.

Comment 2

[Tim Maks van den Broek [:mad_maks]]

added wim to this bug because he is the maintainer of the addon

Comment 3

[Tim Maks van den Broek [:mad_maks]]

As far as i can see is the version on https://addons.mozilla.org/nl/firefox/browse/type:3 based on the "opentaal woordenlijst"

Comment 4

[Hendrik Maryns]

Yes, but there are two identical copies there, and the old one is still there as well.  That should be fixed before this bug can be closed.  The first one (https://addons.mozilla.org/nl/firefox/downloads/file/16472/woordenboek_nederlands-2.0.0-fx+tb+sm.xpi) is deprecated and should be entirely removed, as well as the duplicate.

Moreover, I intended this bug to mean to automatically include it in the next release.  That should be possible, since the license is very liberal.  Same thing in Thunderbird, such that we no longer need the link in the welcome page as it is now.

Comment 5

[Hendrik Maryns]

I see the freeze is very soon now.  Is this included in FF3 yet?  If somebody explains me how to do it, I want to have a shot at it, but I’d have no idea.

Comment 6

[Hendrik Maryns]

Mensen, gebeurt hier eindelijk nog eens iets?

Forgive me my frustration, but I think this is a perfect opportunity to deliver FF3 with the Dutch diectionary packed into it, no need for users to click on a download link somewhere.

If there were instructions somewhere on how to do this, I might have some time in the next weeks to try to build this.

Comment 7

[Tim Maks van den Broek [:mad_maks]]

Attachment: the readme

Comment 8

[Tim Maks van den Broek [:mad_maks]]

Attachment: nl.aff

Comment 9

[Tim Maks van den Broek [:mad_maks]]

i can't attach the dic to the bug; is to large (even compressed).

Pike how do we handle to get the dictionaries in Fx 3 (and Fx 2.x.x.x)

Comment 10

[Tim Maks van den Broek [:mad_maks]]

I think we need to update this to Hunspell to have it included in the Fx 3 builds. Pike is it still possible to add the nl spellcheck into the builds?

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 302578 [details]
the readme

We'll need a triple licensed version, that is, MPL 1.1, and GPL/LGPL in the 2 versions.

Sorry for the lag, nothing is too late here yet, though. I hope.

Comment 12

[Bart Knubben]

@Pike: We (OpenTaal) made the decision to release the Dutch dictionary under both BSD and CC-by. Would that be okay to get it into Fx 3 builds?

Best regards,

Bart Knubben
OpenTaal - http://www.opentaal.org

Comment 13

[Axel Hecht [:Pike]]

Hi Bart, that's cool, thanks. 
Is http://www.opentaal.org/download_spellingbestanden.php the relevant page on your site? It'd be nice to change that to reflect this change. Being German, I understand enough on your site to see that it's been discussed, and that you think that discussion passed when you posted your test version, but still.

Comment 14

[Wim]

What I am curious about is how are the dictionaries packed with the new FF3 and TB going to be updatable? Crosspost from https://bugzilla.mozilla.org/show_bug.cgi?id=388864#c20
Now we are using add-ons with their corresponding update process.

Comment 15

[Bart Knubben]

@Pike: The latetst stable version of the word list files (.aff en .dic) including the legal conditions can be found here: 
http://opentaal.org/bestanden/OT4Firefox/NL_nl_dictionary_files.zip
This is the version of 29-05-07. It is distributed under BSD en CC-by. Please check the file "README_nl_NL.txt" for more information.

Comment 16

[Axel Hecht [:Pike]]

Could someone create a custom build and figure out what happens if you have multiple dutch dictionaries installed?

Anyway, the shipped dictionary is part of the regular app and not an add-on, so it's not going to update via AMO, but via regular firefox app updates.

Comment 17

[Bart Knubben]

> Could someone create a custom build and figure out what happens if you have
> multiple dutch dictionaries installed?
Wouldn't that be similar to the en-US build of Fx that contains the English (US) dictionary? I just quickly tested it with the en-US browser and the en-US dictionary add-on. The add-on just installs and the entry in the right-click menu under "Languages" stays "English / United States". I am not sure which one is leading and what happens when you disable or de-install the add-on dictionary.

Besides, is the info under Comment#15 sufficient for you to get the Dutch spellcheck files into the builds? Please let me know if you need any more information. Thanks!

Comment 18

[Tim Maks van den Broek [:mad_maks]]

(In reply to comment #16)
> Could someone create a custom build and figure out what happens if you have
> multiple dutch dictionaries installed?
> 
> Anyway, the shipped dictionary is part of the regular app and not an add-on, so
> it's not going to update via AMO, but via regular firefox app updates.
> 

I have compiled a version ( http://www.mozilla-nl.org/downloads/firefox-3.0pre.nl.linux-i686.tar.bz2 , minefield version: some parts of the UI are not right like downloads and preferences/privacy!!!) and installed the two dictionaries (clean profile). The first one does not show (has the same name, "nederlands") and the opentaal version shows, "nederlands (groene boekje 2005)".

Then i used a old profile where both dictionaries where installed and i didn't see a problem. In the list i see "nederlands" and "nederlands (groene boekje 2005)"

Comment 19

[Axel Hecht [:Pike]]

Sounds good to me.

Comment 20

[Tim Maks van den Broek [:mad_maks]]

The dicts from #15 are committed, from now we have a nl dct included into the builds. Thanks everybody!

p.s. the compiled test version will be removed from the server.

Comment 21

[Bart Knubben]

Great! One last thing. The name "Nederlands (Groene Boekje 2005)" is caused by the filenames of the .aff and .dic. If you would like to have just a standard name (i.e. "Nederlands"), you should rename the .aff and .doc to "nl.aff" and "nl.dic". Such names are probably also in accordance with the applicable convention within Mozilla. At least, the dictionary files within the XPI of Wim MoZes do have those names. As you know we are working on integrating the two existing dictionary add-ons (see: https://bugzilla.mozilla.org/show_bug.cgi?id=388864). I believe the names in his file will be leading. 

Comment 22

[Tim Maks van den Broek [:mad_maks]]

see http://mxr.mozilla.org/l10n/source/nl/extensions/spellcheck/hunspell/ :-)

i did the renaming allready because the "(" in the naming causes a error in the buildproces. The names in commend #18 are from the two dictionary addons i had installed for testing if there where any conflicts.

Comment 23

[Bart Knubben]

Perfect! Last question: Does this mean that the word list will be included in the future builds of both FF and TB?

Comment 24

[Tim Maks van den Broek [:mad_maks]]

Yes, they are from now on included in the nightly build of Fx and TB (Seamonkey will follow)