Closed
Bug 383947
Opened 18 years ago
Closed 18 years ago
nsBrowserContentHandler.js leaks nsCommandLine
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: neil)
Details
(Keywords: memory-leak)
Attachments
(1 file)
|
505 bytes,
patch
|
bzbarsky
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
At least that's the best I can tell. For some reason that component's scope is not unloaded or something (I think that's a known problem with JS components), and we never null out realCmdLine at shutdown... So nsCommandLine shows up in the leak log, making other leak debugging more confusing.
Flags: blocking-seamonkey2.0a1?
|
Assignee | |
Comment 1•18 years ago
|
||
We should be able to null out realCmdLine much earlier than shutdown ;-)
Sorry, but I wasn't going to do a -u30 to give you the whole block context.
Assignee: general → neil
Status: NEW → ASSIGNED
Attachment #267956 -
Flags: superreview?(jag)
Attachment #267956 -
Flags: review?(bzbarsky)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 267956 [details] [diff] [review]
Proposed patch
That's alright, bugzilla's diff view mode let me see the context I needed. sr=jag
Attachment #267956 -
Flags: superreview?(jag) → superreview+
|
Reporter | |
Comment 3•18 years ago
|
||
Comment on attachment 267956 [details] [diff] [review]
Proposed patch
If none of those methods that use it are called after that... sure.
Attachment #267956 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
||
Updated•17 years ago
|
Flags: blocking-seamonkey2.0a1?
You need to log in
before you can comment on or make changes to this bug.
Description
•