Closed
Bug 383961
Opened 17 years ago
Closed 17 years ago
[FIXr]Fix loadgroup mess in URILoader
Categories
(Core Graveyard :: Embedding: APIs, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file, 1 obsolete file)
|
1.17 KB,
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
bzbarsky
:
approval1.9+
|
Details | Diff | Splinter Review |
Instead of what we do now when looking for a loadgroup, we should:
if (!loadgroup) {
// If no docloader in load cookie, create one
// Get loadgroup off docloader
}
Not sure how best to handle channels with an existing loadgroup when !aChannelIsOpen.
|
||
Updated•17 years ago
|
Summary: Fix loadgrop mess in URILoader → Fix loadgroup mess in URILoader
|
Assignee | |
Comment 1•17 years ago
|
||
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #274228 -
Flags: superreview?(cbiesinger)
Attachment #274228 -
Flags: review?(cbiesinger)
|
|
Assignee | |
Updated•17 years ago
|
Priority: -- → P3
Summary: Fix loadgroup mess in URILoader → [FIX]Fix loadgroup mess in URILoader
Target Milestone: --- → mozilla1.9beta2
|
|
Assignee | |
Comment 2•17 years ago
|
||
Attachment #274228 -
Attachment is obsolete: true
Attachment #274258 -
Flags: superreview?(cbiesinger)
Attachment #274258 -
Flags: review?(cbiesinger)
Attachment #274228 -
Flags: superreview?(cbiesinger)
Attachment #274228 -
Flags: review?(cbiesinger)
|
||
Updated•17 years ago
|
Attachment #274258 -
Flags: superreview?(cbiesinger)
Attachment #274258 -
Flags: superreview+
Attachment #274258 -
Flags: review?(cbiesinger)
Attachment #274258 -
Flags: review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Comment on attachment 274258 [details] [diff] [review] Actually compiling This makes us actually put the channel in the loadgroup we just created if the load is not happening in a docshell. Risk is extremely low.
Attachment #274258 -
Flags: approval1.9?
|
|
Assignee | |
Updated•17 years ago
|
Summary: [FIX]Fix loadgroup mess in URILoader → [FIXr]Fix loadgroup mess in URILoader
|
|
Assignee | |
Comment 4•17 years ago
|
||
Comment on attachment 274258 [details] [diff] [review] Actually compiling Self-approving, dammit. This is trivial.
Attachment #274258 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•