Closed Bug 383961 Opened 13 years ago Closed 13 years ago

[FIXr]Fix loadgroup mess in URILoader

Categories

(Core Graveyard :: Embedding: APIs, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9beta1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file, 1 obsolete file)

Instead of what we do now when looking for a loadgroup, we should:

 if (!loadgroup) {
   // If no docloader in load cookie, create one
   // Get loadgroup off docloader
 }

Not sure how best to handle channels with an existing loadgroup when !aChannelIsOpen.
Summary: Fix loadgrop mess in URILoader → Fix loadgroup mess in URILoader
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #274228 - Flags: superreview?(cbiesinger)
Attachment #274228 - Flags: review?(cbiesinger)
Priority: -- → P3
Summary: Fix loadgroup mess in URILoader → [FIX]Fix loadgroup mess in URILoader
Target Milestone: --- → mozilla1.9beta2
Attachment #274228 - Attachment is obsolete: true
Attachment #274258 - Flags: superreview?(cbiesinger)
Attachment #274258 - Flags: review?(cbiesinger)
Attachment #274228 - Flags: superreview?(cbiesinger)
Attachment #274228 - Flags: review?(cbiesinger)
Attachment #274258 - Flags: superreview?(cbiesinger)
Attachment #274258 - Flags: superreview+
Attachment #274258 - Flags: review?(cbiesinger)
Attachment #274258 - Flags: review+
Comment on attachment 274258 [details] [diff] [review]
Actually compiling

This makes us actually put the channel in the loadgroup we just created if the load is not happening in a docshell.  Risk is extremely low.
Attachment #274258 - Flags: approval1.9?
Summary: [FIX]Fix loadgroup mess in URILoader → [FIXr]Fix loadgroup mess in URILoader
Comment on attachment 274258 [details] [diff] [review]
Actually compiling

Self-approving, dammit.  This is trivial.
Attachment #274258 - Flags: approval1.9? → approval1.9+
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.