383976 - [FIX]Eliminate oscillations when caller reads multiplex stream with ReadSegments

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Right now, doing a file upload does oscillating packet size requests because we start with our 4KB block boundary not lined up with the file and then end up sending packets of size X and 4096 - X down the pipe.  See bug 378629 for the nitty-gritty discussion.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Possible patch

This seems a little evil, but works....

Comment 2

[Boris Zbarsky [:bzbarsky]]

Note that this increases the number of short reads caused by buffered streams, which makes bug 387588 more likely to bite.  Fix is posted there, though.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

shouldn't Read also reset mBlockNextReadSegments to false, like Seek?

+    return aEventTarget->Dispatch(runnable, nsIEventTarget::DISPATCH_NORMAL);

aEventTarget may be null...

and what if no data is available in the stream?

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 267913 [details] [diff] [review]
Possible patch

marking r-, the asyncWait implementation is incorrect

Comment 5

[Boris Zbarsky [:bzbarsky]]

After talking to biesi, we're going to just take the patch in bug 137155 on trunk and hope that the NSS changes have made bug 334142 go away.  That patch really does give us the behavior we want.