Closed
Bug 384013
Opened 17 years ago
Closed 15 years ago
Brand names translated in gu-IN!
Categories
(Mozilla Localizations :: gu-IN / Gujarati, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ankit, Assigned: ankit)
References
Details
(Keywords: fixed1.8.1.5)
Attachments
(1 file)
32.00 KB,
patch
|
ankit
:
review+
Pike
:
approval1.8.1.5+
|
Details | Diff | Splinter Review |
Hi, Initially when we started translation of Firefox/Thunderbird, we didn't know that we shouldn't translate brand names like Firefox/Thunderbird/Mozilla. By reference of bug #334837 i got to know that i can break the install/uninstall process. So, i have to revert back those translations into english for brand-names. Hence, can somebody please approve the patch i attach here. So that the other bug can be resolved. Thanks, Ankit Patel
Comment 1•17 years ago
|
||
Ankit, please review the patch to make sure it's the right one. If so, please request approval1.8.1.5.
Attachment #267957 -
Flags: review?(ankit644)
Assignee | ||
Comment 2•17 years ago
|
||
Patch looks correct to me, as per my modifications. Please approve it.
Flags: blocking1.8.1.5?
Comment 3•17 years ago
|
||
This bug is not blocking1.8.1.5, marking up as such. Please set the approval1.8.1.5 flag to ? on the patch itself to get approval for that landing.
Flags: blocking1.8.1.5? → blocking1.8.1.5-
Assignee | ||
Updated•17 years ago
|
Flags: blocking1.8.1.5- → blocking1.8.1.5?
Comment 4•17 years ago
|
||
No, not the blocking flag on the bug. Click on the details link for the attachement, that's the form where you can add your review and request approval.
Flags: blocking1.8.1.5? → blocking1.8.1.5-
Assignee | ||
Updated•17 years ago
|
Attachment #267957 -
Flags: approval1.8.1.5?
Assignee | ||
Updated•17 years ago
|
Attachment #267957 -
Flags: review?(ankit644) → review+
Comment 5•17 years ago
|
||
Thanks, I'll go through the approval queue once I find out what we're doing.
Comment 6•17 years ago
|
||
Comment on attachment 267957 [details] [diff] [review] the patch as seen by bonsai and a tad of shell hacking [gu-IN] after-the-fact approval of landing after .4 freeze. Please use the verified1.8.1.5 flag to track testing of the current builds.
Attachment #267957 -
Flags: approval1.8.1.5? → approval1.8.1.5+
Updated•17 years ago
|
Keywords: fixed1.8.1.5
Comment 7•15 years ago
|
||
FIXED for a while now.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•