384080 - [Mac Classic] dialogheaders should not be displayed in Prefs and MailNews account settings

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Stefan [:stefanh]]

This is due to:

pinstripe/global/global.css:

193 #header {
194         display: none !important;
195 }


pinstripe/global/dialog.css:

80 .dialogheader-title {
81   margin: 0px !important;
82   font-size: larger;
83   font-weight: bold;
84   display: none;
85 }

I think we might be able to remove/move the #header rule. The .dialogheader-title rules in dialog.css needs to be investigated a bit, since they probably affect lots of stuff.

Comment 1

[Stefan [:stefanh]]

Just to make it clear: In the account settings, it's only the .dialogheader-title label that is unvisible (the background is there).

Comment 2

[Stefan [:stefanh]]

So... I don't think any mac apps display any headers in their pref windows - that's the reason their hidden in toolkit. On the 1.7 branch, FF had the same pref layout as SeaMonkey has now, I think (that's prolly the reason for the #header rule). From a quick look it appears that not even MSWord (same layout as SeaMonkey) from 2004 display any headers in the prefs.

Comment 3

[Karsten Düsterloh]

Well, we did before, we do on the platforms and it doesn't actually hurt any rules, so I still think we should get 'em back.

Comment 4

[Stefan [:stefanh]]

(In reply to comment #3)
> Well, we did before, we do on the platforms and it doesn't actually hurt any
> rules, so I still think we should get 'em back.
> 

I don't know if I agree (not even the ancient IE5.2 has headers displayed in the pref panels). Besides, several pref panels doesn't fit with the headers displayed.

Comment 5

[Stefan [:stefanh]]

Note that with the new pref pane it's really an overkill to display the headers - those are displayed in the titlebar afaics.

This means that:
1) First we display "abc" in the tree
2) Then we display "abc" in the titlebar
3) And then we should display "abc" in the header?

Comment 6

[Stefan [:stefanh]]

Note that an argument saying "we did it before" isn't really valid when it comes to mac - we did (and still do) lots of things wrong on mac.

Comment 7

[Karsten Düsterloh]

Attachment: v1a: ifdef out code irrelevant to Mac [checked in with adjustment (comment #15)]

Our legacy pref window's title is just "preferences", our new toolkit one displays the pane label there. Thus I came to agree that we can hide it for Mac.
This version 1a does this by ifdeffing code not needed for Mac.

Comment 8

[Karsten Düsterloh]

Attachment: [net hickup]

Comment 9

[Karsten Düsterloh]

Attachment: v1b: just hide the xul element for Mac

This version 1b keeps the XUL the same on all platforms and just hides the unneeded stuff on Mac. 

I'd prefer this solution.

Comment 10

[[e-mail]]

How making the dialogheader hidden by default and #ifdef the code that unhides?

Comment 11

[Stefan [:stefanh]]

(preferences.xml)

113 #ifdef XP_WIN
114              title="&preferencesDefaultTitleWin.title;"
115 #else
116              title="&preferencesDefaultTitleMac.title;"
117 #endif

This is never used then?


Btw, what is correct behaviour on other platforms? Now when I'm thinking of it I'm a bit unsure if it's correct to have the pane's title as the window's title... This is of course better than before, but for mac I suspect the "real" solution would be to have "preferencesDefaultTitleMac.title" in the window's title and at the same time not having a headertitle... Few mac apps have this kind of preference window, but the ones I've checked all have it laid out like this.

Comment 12

[[e-mail]]

(In reply to comment #11)
>I'm a bit unsure if it's correct to have the pane's title as the window's title
There's not a lot we can do about that, because it's hardcoded into toolkit.

Comment 13

[Stefan [:stefanh]]

Comment on attachment 296854 [details] [diff] [review]
v1a: ifdef out code irrelevant to Mac [checked in with adjustment (comment #15)]

If you really want to keep the xul unchanged, I'm all in for Neil's suggestion in comment #10.

Comment 14

[[e-mail]]

Comment on attachment 296854 [details] [diff] [review]
v1a: ifdef out code irrelevant to Mac [checked in with adjustment (comment #15)]

sr=me, optionally using <xul:dialogheader anonid="paneHeader" hidden="true"/> instead.

Comment 15

[Karsten Düsterloh]

Comment on attachment 296854 [details] [diff] [review]
v1a: ifdef out code irrelevant to Mac [checked in with adjustment (comment #15)]

Landed on trunk with hidden="true".

I'll leave this bug open for the MailNews account settings, which may be somewhat harder to fix, because it's a shared file.

Comment 16

[Stefan [:stefanh]]

Adjusting the title a bit...

Comment 17

[Karsten Düsterloh]

Stefan fixed the remaining parts in bug 460699.