384112 - -moz-appearance: menulist-button broken in GTK

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[pantsgolem]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9a6pre) Gecko/20070604 Minefield/3.0a6pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9a6pre) Gecko/20070605 Minefield/3.0a6pre

Between 20070604 and 20070605, -moz-appearance: menulist-button (used, for example, in themes with a "native" location bar) stopped working in GTK.  Works fine in Windows.

Reproducible: Always

Steps to Reproduce:
1. Enable the default theme
2. Put ".autocomplete-history-dropmarker { -moz-appearance: menulist-button !important; }" in userChrome.css
3. Start firefox
Actual Results:  
The autocomplete dropdown button appears in the default theme's style.

Expected Results:  
The dropdown button should be an approximation of a native GTK widget.

The timing of this bug coincides with the initial checkin for bug 329846.

Incidentally, is there a bug for improving the appearance of menulist-button on GTK?

Comment 1

[Michael Ventnor]

I commented out dropdown buttons because they look uuuug-ly when they're used with a combobox that has styles applied to it. 

They're not really native anyway, they're just regular buttons with the downward scroll button arrow applied on it. I could turn it back on but I'd prefer not to, since those buttons stick out like a sore thumb.

Comment 2

[pantsgolem]

I have three problems with that:

1. Commenting out that line disabled the pseudo-native dropdown in chrome as well as content, and menulist-button is necessary for themes that aim for a native addressbar.
2. Enabling the pseudo-native dropdown in content is consistent with the behavior on Windows.
3. If the dropdown button is enabled in source, users are free to override in CSS.  By disabling it in source, it's disabled for everybody.

Comment 3

[Michael Ventnor]

Attachment: Patch

This turns it back on, because I found what I wanted to style the button more natively than what we did before (which was just a normal button).

Comment 4

[Michael Ventnor]

Oh, and the reason for this:

-      // for dropdown textfields, look at the parent frame (textbox or menulist)
-      if (aWidgetType == NS_THEME_DROPDOWN_TEXTFIELD)
-        aFrame = aFrame->GetParent();

is that the textbox wouldn't repaint after it lost focus. It would still glow even if another textbox had focus.

Comment 5

[Reed Loden [:reed]]

Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.30; previous revision: 1.29
done
Checking in widget/src/gtk2/nsNativeThemeGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v  <--  nsNativeThemeGTK.cpp
new revision: 1.103; previous revision: 1.102
done

Comment 6

[Steve England [:stevee]]

could this have caused bug 396299?

Comment 7

[pantsgolem]

Attachment: screenshot: no arrow, wrong height

This is what styled <select> looks like for me now.  There's no arrow and the button does not extend to the bottom of the box.

This was with gtk 2.11.6 (and now with 2.12.0) so I wouldn't be surprised if something there changed.

Comment 8

[Michael Ventnor]

What theme is that? Clearlooks?
BTW it WFM on GTK 2.10.0

Comment 9

[Michael Ventnor]

I've been tricked. It seems the native entry button isn't flexible in its size at all, it just so happens that most styled dropdowns do fit rather nicely. Thats why you're seeing the space.

As for the arrow, I can't really explain that. I'll have to look into it.

Bah, can someone backout this patch and reopen the bug?

Comment 10

[pantsgolem]

That particular theme is QtCurve, but I've tried Clearlooks and Xfce as well, and it's the same.

Comment 11

[Reed Loden [:reed]]

Patch backed out.

Comment 12

[Michael Ventnor]

Attachment: Patch 2

This restores our old buttons, but only for XUL which was mostly affected by the regression. Under HTML the "regression" is actually the better scenario, the GTK buttons have the wrong size and shape and they don't fit in at all with the generic dropdown's border.

I think this is the best compromise.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 284587 [details] [diff] [review]
Patch 2

+    if (aFrame)
+      return aFrame->GetContent()->IsNodeOfType(nsINode::eXUL) &&
+             !IsWidgetStyled(aPresContext, aFrame, aWidgetType);
+    else
+      return !IsWidgetStyled(aPresContext, aFrame, aWidgetType);

Simplify this to
  (!aFrame || aFrame->GetContent()->IsNodeOfType(nsINode::eXUL)) &&
  !IsWidgetStyled(aPresContext, aFrame, aWidgetType)

Comment 14

[Michael Ventnor]

Attachment: Simplified

This is a very trivial patch that fixes a noticeable regression with dropdown buttons since the landing of native themes.

Comment 15

[Michael Ventnor]

Although not critical, this patch would be a good idea for Beta 1 so people can confidently use this button in their themes on Linux. This patch is also quite small and safe.

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 284601 [details] [diff] [review]
Simplified

a=endgame drivers for M9

Comment 17

[Reed Loden [:reed]]

Checking in widget/src/gtk2/nsNativeThemeGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v  <--  nsNativeThemeGTK.cpp
new revision: 1.106; previous revision: 1.105
done