Closed Bug 384153 Opened 14 years ago Closed 14 years ago

symbol upload not removing zip file on remote host

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

Details

Attachments

(1 file)

use unzip -o
673 bytes, patch
benjamin
: review+
Details | Diff | Splinter Review 
There are a ton of zip files hanging out in symbols_ffx on stage, starting with:
crashreporter-symbols-2007051104.zip.  That shouldn't be happening.
It's the OSX tinderbox:

replace JavaEmbeddingPlugin/03AAB9494904AC0F87514F6CAF612FDC0/JavaEmbeddingPlugin.sym? [y]es, [n]o, [A]ll, [N]one, [r]ename:  NULL
(assuming [N]one)
  inflating: libbrowsercomps.dylib/17D034092017F01976CED955EF07DC510/libbrowsercomps.dylib.sym  
  inflating: libbrowsercomps.dylib/99311F587BFA6313DB4B2F512DEE75A20/libbrowsercomps.dylib.sym  
  inflating: libnssckbi.dylib/7CAAC0A3CE5905A05D85D030604512C40/libnssckbi.dylib.sym  
  inflating: libnssckbi.dylib/7DFA75AC1168D0D05E3539DE9A424E450/libnssckbi.dylib.sym  
  inflating: updater/9E755F5167499063C1711A2C1F92D8D50/updater.sym  
  inflating: updater/F00635E3985F52BC591B9FDC80B4A0130/updater.sym  
  inflating: xpicleanup/00E7934F8931621A676BD5F3562A5F1A0/xpicleanup.sym  
  inflating: xpicleanup/2FD931482BBB21EA804676D3C0E0B4B10/xpicleanup.sym  
  inflating: XUL/4C5558000001000000010000000000070/XUL.sym  
  inflating: XUL/4C5558000001000000010000000000120/XUL.sym  
make: *** [uploadsymbols] Error 1
Attached patch use unzip -o — — Splinter Review 
unzip -o forces overwriting of existing files.  Since mac symbols can have tbe same signature (since it's just a hash), this is necessary to prevent unzip from failing.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #268090 - Flags: review?(benjamin)
Attachment #268090 - Flags: review?(benjamin) → review+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.