Closed
Bug 384154
Opened 17 years ago
Closed 17 years ago
layout-debug component does not build
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: MatsPalmgren_bugz, Assigned: ginnchen+exoracle)
Details
Attachments
(1 file)
3.54 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
STEPS TO REPRODUCE 1. enable the extension "layout-debug" in your .mozconfig 2. configure and build ACTUAL RESULT c++ -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe -DDEBUG -D_DEBUG -DDEBUG_mats -DTRACING -g -fno-inline -O -fPIC -shared -Wl,-z,defs -Wl,-h,libgkdebug.so -o libgkdebug.so nsDebugFactory.o nsLayoutDebugCLH.o nsLayoutDebuggingTools.o nsRegressionTester.o -lpthread ../../../dist/lib/libunicharutil_s.a -L../../../dist/bin -Wl,-rpath-link,../../../dist/bin -lxpcom -lxul -L../../../dist/bin -L../../../dist/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl -Wl,-Bsymbolic -ldl -lm nsDebugFactory.o: In function `NSGetModule': /usr/moz/ff2/mozilla/extensions/layout-debug/src/nsDebugFactory.cpp:115: undefined reference to `NS_NewGenericModule2(nsModuleInfo const*, nsIModule**)' nsDebugFactory.o: In function `nsCOMPtr<nsICategoryManager>::assign_from_gs_contractid(nsGetServiceByContractID, nsID const&)': /usr/moz/ff2/mozilla/extensions/layout-debug/src/../../../dist/include/xpcom/nsCOMPtr.h:1284: undefined reference to `nsGetServiceByContractID::operator()(nsID const&, void**) const' nsLayoutDebugCLH.o: In function `nsLayoutDebugCLH::GetHelpInfo(nsACString_internal&)': /usr/moz/ff2/mozilla/extensions/layout-debug/src/nsLayoutDebugCLH.cpp:120: undefined reference to `nsACString_internal::Assign(nsACString_internal const&)' nsLayoutDebugCLH.o: In function `nsLayoutDebugCLH::QueryInterface(nsID const&, void**)': /usr/moz/ff2/mozilla/extensions/layout-debug/src/nsLayoutDebugCLH.cpp:62: undefined reference to `NS_TableDrivenQI(void*, QITableEntry const*, nsID const&, void**)' nsLayoutDebugCLH.o: In function `nsCreateInstanceByContractID': /usr/moz/ff2/mozilla/extensions/layout-debug/src/../../../dist/include/xpcom/nsComponentManagerUtils.h:96: undefined reference to `vtable for nsCreateInstanceByContractID' nsLayoutDebugCLH.o: In function `nsCString': /usr/moz/ff2/mozilla/extensions/layout-debug/src/../../../dist/include/string/nsTString.h:428: undefined reference to `nsACString_internal::nsACString_internal(char*, unsigned int, unsigned int)' nsLayoutDebugCLH.o: In function `~nsCString': ... etc ...
Reporter | ||
Comment 1•17 years ago
|
||
Benjamin says "It looks like it lives outside of libxul, which means that it needs to start using frozen linkage." Personally, I still use -layout-debug every now and then to get a quick dump of a frame/content tree, but I can get that through a debugger as well so I wouldn't miss it much if we removed it...
Comment 2•17 years ago
|
||
Getting frame trees via a debugger is a _lot_ more pain, and layout-debug outputs all sorts of other things that are hard to get in a debugger. I use it all the time. We need to fix this. What bug caused the breakage? This built as of MOZ_CO_DATE="Sat Jun 9 00:21:02 CDT 2007"...
Severity: minor → blocker
Reporter | ||
Comment 3•17 years ago
|
||
I think it was bug 345517, the "2007-06-12 06:22" checkin but I'm not sure...
Comment 4•17 years ago
|
||
Ah, looks like this is not a problem with --disable-libxul. I assume most people's debug builds in fact use that, so this is a lot less of a problem.
Severity: blocker → normal
tested with layout-debug+enable-libxul, layout-debug+disable-libxul, no layout-debug+enable-libxul
Updated•17 years ago
|
Attachment #268475 -
Flags: review?(benjamin) → review+
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•