Closed Bug 384239 Opened 16 years ago Closed 16 years ago

"Search in Bookmarks" search field looks much worse on mac than it does on windows

Categories

(Firefox :: Bookmarks & History, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3 alpha8

People

(Reporter: moco, Assigned: dietrich)

References

Details

(Whiteboard: [places-ui])

Attachments

(4 files)

"Search in Bookmarks" search field looks much worse on mac than it does on windows

For example, it is is much taller.

screen shot coming.

I'm wondering if it should look more like the search box in the browser, where the drop down is centered vertically?
Flags: blocking-firefox3?
This entire window is due for a pretty major redesign (a thread will start soon in dev.apps.firefox), so we may want to hold off on tweaking the current interface.
re-assign to faaborg so that no one takes this an implements it before we have a redesign.
Assignee: nobody → faaborg+bugzilla
Isn't there suppose to be an icon next to the arrow? Like Thunderbird's search field. 
Flags: blocking-firefox3? → blocking-firefox3+
Target Milestone: --- → Firefox 3 M8
Whiteboard: [places-ui]
http://people.mozilla.com/~faaborg/files/granParadisoUI/placesOrganizer_i5WindowLayout.png

per the mockup, we can remove the folder filter drop-arrow altogether.
Attached patch fix v1Splinter Review
this just removes the filter popup altogether for now. we might hook that functionality back up later via different UI, so i've left the plumbing intact.
Assignee: faaborg+bugzilla → dietrich
Status: NEW → ASSIGNED
Attachment #277158 - Flags: review?(sspitzer)
Comment on attachment 277158 [details] [diff] [review]
fix v1

what about onPlaceSelected() and other code in places.js?  

If we remove this from places.xul, lots of stuff will break.
Attachment #277158 - Flags: review?(sspitzer)
To put the removal of the folder filter drop down into context: the plan is to display a scope bar control when the user performs a search:

http://people.mozilla.com/~faaborg/files/granParadisoUI/placesSearch_i4AdvancedSearch.png

(note that this mockup isn't final)

We will still need to know what folder the user was in, because that will be one of the options in the scope bar.
Comment on attachment 277158 [details] [diff] [review]
fix v1

r=sspitzer, dietrich explained over irc.

do we have a spin off bug to track faaborg's "scope bar"?
Attachment #277158 - Flags: review+
(In reply to comment #12)
> (From update of attachment 277158 [details] [diff] [review])
> r=sspitzer, dietrich explained over irc.
> 
> do we have a spin off bug to track faaborg's "scope bar"?
> 

no, that mockup isn't final yet. the search builder is currently bug 387744.
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.77; previous revision: 1.76
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
verified with - Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.