Closed
Bug 384419
Opened 17 years ago
Closed 17 years ago
Drop-down menus at www.ati.com do not display correctly.
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha6
People
(Reporter: smaug, Assigned: MatsPalmgren_bugz)
References
()
Details
(Keywords: regression, testcase)
Attachments
(3 files, 2 obsolete files)
237 bytes,
text/html
|
Details | |
3.08 KB,
patch
|
Details | Diff | Splinter Review | |
2.18 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Make sure the window is maximized and hover over "Drivers&Software". The menu displays to the left of where it should be. This is a regression from bug 375003.
Flags: blocking1.9?
Reporter | ||
Updated•17 years ago
|
URL: www.ati.com
Reporter | ||
Updated•17 years ago
|
Keywords: regression
Updated•17 years ago
|
URL: www.ati.com → http://www.ati.com/
Updated•17 years ago
|
OS: Linux → All
Hardware: PC → All
Assignee | ||
Comment 1•17 years ago
|
||
Updated•17 years ago
|
Flags: in-testsuite?
Assignee | ||
Comment 2•17 years ago
|
||
A rel.pos. inside a <table> ("offset parent") directly inside <body>.
Attachment #268359 -
Attachment is obsolete: true
Assignee | ||
Comment 3•17 years ago
|
||
We want to add in the parent offset unless we're leaving the loop. There must be a better way to write this code... Intuitively I'd like to add in the offset at the end of the loop instead, but it looks like there is some edge cases (parent==docElement or <body>) where we want to add in the parent offset as well...
Comment 4•17 years ago
|
||
> !(!isPositioned && isOffsetParent)
isPositioned || !isOffsetParent
?
Blocks: 384431
Assignee | ||
Comment 5•17 years ago
|
||
(In reply to comment #4) Boris, I intentionally wrote it like that to highlight that the expression should be the same as the one ~10 lines down to exit the loop.
Assignee | ||
Comment 6•17 years ago
|
||
Assignee | ||
Comment 7•17 years ago
|
||
Attachment #268381 -
Attachment is obsolete: true
Attachment #268501 -
Flags: superreview?(roc)
Attachment #268501 -
Flags: review?(roc)
Assignee | ||
Comment 8•17 years ago
|
||
The patch also fixes Zimbra (bug 384431).
Comment on attachment 268501 [details] [diff] [review] Patch rev. 1 gah this code is confusing. isOffsetParent needs a much better name...
Attachment #268501 -
Flags: superreview?(roc)
Attachment #268501 -
Flags: superreview+
Attachment #268501 -
Flags: review?(roc)
Attachment #268501 -
Flags: review+
Assignee | ||
Comment 10•17 years ago
|
||
Checked in to trunk at 2007-06-23 00:39 PDT. -> FIXED
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite?
Flags: in-testsuite+
Flags: blocking1.9?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha6
You need to log in
before you can comment on or make changes to this bug.
Description
•