Closed Bug 384419 Opened 17 years ago Closed 17 years ago

Drop-down menus at www.ati.com do not display correctly.

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha6

People

(Reporter: smaug, Assigned: MatsPalmgren_bugz)

References

()

Details

(Keywords: regression, testcase)

Attachments

(3 files, 2 obsolete files)

Make sure the window is maximized and hover over "Drivers&Software".
The menu displays to the left of where it should be.
This is a regression from bug 375003.
Flags: blocking1.9?
Keywords: regression
OS: Linux → All
Hardware: PC → All
Attached file Testcase (obsolete) —
Assignee: nobody → mats.palmgren
Keywords: testcase
Flags: in-testsuite?
Attached file Simplified testcase
A rel.pos. inside a <table> ("offset parent") directly inside <body>.
Attachment #268359 - Attachment is obsolete: true
Attached patch wip (obsolete) — Splinter Review
We want to add in the parent offset unless we're leaving the loop.
There must be a better way to write this code...
Intuitively I'd like to add in the offset at the end of the loop instead,
but it looks like there is some edge cases (parent==docElement or <body>)
where we want to add in the parent offset as well...
> !(!isPositioned && isOffsetParent)

  isPositioned || !isOffsetParent

?
Blocks: 384431
(In reply to comment #4)
Boris, I intentionally wrote it like that to highlight that the expression
should be the same as the one ~10 lines down to exit the loop.
Attached patch MochitestSplinter Review
Attached patch Patch rev. 1Splinter Review
Attachment #268381 - Attachment is obsolete: true
Attachment #268501 - Flags: superreview?(roc)
Attachment #268501 - Flags: review?(roc)
The patch also fixes Zimbra (bug 384431).
Comment on attachment 268501 [details] [diff] [review]
Patch rev. 1

gah this code is confusing. isOffsetParent needs a much better name...
Attachment #268501 - Flags: superreview?(roc)
Attachment #268501 - Flags: superreview+
Attachment #268501 - Flags: review?(roc)
Attachment #268501 - Flags: review+
Checked in to trunk at 2007-06-23 00:39 PDT.

-> FIXED
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite?
Flags: in-testsuite+
Flags: blocking1.9?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha6
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: