384497 - Add a parameter that enables debug mode for SMTP

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, enhancement)

Description

[Max Kanat-Alexander]

It's really simple to enable Net::SMTP's Debug mode, which prints the whole SMTP transaction to stderr.

Lots of people have various problems in Bugzilla with mail, in 3.0 and before. We get lots of support requests. Thus, I'd like to add this parameter even to the 3.0 branch--it's a pretty trivial change.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Here it is! Pretty simple.

Comment 2

[Frédéric Buclin]

Why not turning it on, always? You would only get debug messages on error, not when emails are sent successfully, right? I see no problem filling the error log with debug messages without the agreement of admins.

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> Why not turning it on, always? You would only get debug messages on error, not
> when emails are sent successfully, right?

  No, you get the messages always. And it's something like 150 lines per message--it'd slow Bugzilla down to a crawl if it was on all the time.

Comment 4

[Frédéric Buclin]

Comment on attachment 268431 [details] [diff] [review]
v1

Looks good but I cannot test it as I don't use SMTP. r=LpSolit assuming you have tested it. I will let you approve it.

Comment 5

[Max Kanat-Alexander]

Yep, I tested it.

tip:

Checking in Bugzilla/Mailer.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Mailer.pm,v  <--  Mailer.pm
new revision: 1.10; previous revision: 1.9
done
Checking in Bugzilla/Config/MTA.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/MTA.pm,v  <--  MTA.pm
new revision: 1.15; previous revision: 1.14
done
Checking in template/en/default/admin/params/mta.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/mta.html.tmpl,v  <--  mta.html.tmpl
new revision: 1.10; previous revision: 1.9
done


3.0:

Checking in Bugzilla/Mailer.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Mailer.pm,v  <--  Mailer.pm
new revision: 1.7.2.3; previous revision: 1.7.2.2
done
Checking in Bugzilla/Config/MTA.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/MTA.pm,v  <--  MTA.pm
new revision: 1.14.2.1; previous revision: 1.14
done
Checking in template/en/default/admin/params/mta.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/mta.html.tmpl,v  <--  mta.html.tmpl
new revision: 1.9.2.1; previous revision: 1.9
done

Comment 6

[Max Kanat-Alexander]

Added to 3.0 relnotes in bug 391233.