Last Comment Bug 384497 - Add a parameter that enables debug mode for SMTP
: Add a parameter that enables debug mode for SMTP
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Email Notifications (show other bugs)
: 3.0
: All All
: -- enhancement (vote)
: Bugzilla 3.0
Assigned To: Max Kanat-Alexander
: default-qa
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-06-14 15:49 PDT by Max Kanat-Alexander
Modified: 2008-01-04 06:18 PST (History)
0 users
mkanat: approval+
mkanat: approval3.0+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
v1 (2.11 KB, patch)
2007-06-14 16:07 PDT, Max Kanat-Alexander
LpSolit: review+
Details | Diff | Splinter Review

Description Max Kanat-Alexander 2007-06-14 15:49:54 PDT
It's really simple to enable Net::SMTP's Debug mode, which prints the whole SMTP transaction to stderr.

Lots of people have various problems in Bugzilla with mail, in 3.0 and before. We get lots of support requests. Thus, I'd like to add this parameter even to the 3.0 branch--it's a pretty trivial change.
Comment 1 Max Kanat-Alexander 2007-06-14 16:07:32 PDT
Created attachment 268431 [details] [diff] [review]
v1

Here it is! Pretty simple.
Comment 2 Frédéric Buclin 2007-06-15 06:49:39 PDT
Why not turning it on, always? You would only get debug messages on error, not when emails are sent successfully, right? I see no problem filling the error log with debug messages without the agreement of admins.
Comment 3 Max Kanat-Alexander 2007-06-15 15:37:48 PDT
(In reply to comment #2)
> Why not turning it on, always? You would only get debug messages on error, not
> when emails are sent successfully, right?

  No, you get the messages always. And it's something like 150 lines per message--it'd slow Bugzilla down to a crawl if it was on all the time.
Comment 4 Frédéric Buclin 2007-06-17 11:17:45 PDT
Comment on attachment 268431 [details] [diff] [review]
v1

Looks good but I cannot test it as I don't use SMTP. r=LpSolit assuming you have tested it. I will let you approve it.
Comment 5 Max Kanat-Alexander 2007-06-17 11:58:25 PDT
Yep, I tested it.

tip:

Checking in Bugzilla/Mailer.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Mailer.pm,v  <--  Mailer.pm
new revision: 1.10; previous revision: 1.9
done
Checking in Bugzilla/Config/MTA.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/MTA.pm,v  <--  MTA.pm
new revision: 1.15; previous revision: 1.14
done
Checking in template/en/default/admin/params/mta.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/mta.html.tmpl,v  <--  mta.html.tmpl
new revision: 1.10; previous revision: 1.9
done


3.0:

Checking in Bugzilla/Mailer.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Mailer.pm,v  <--  Mailer.pm
new revision: 1.7.2.3; previous revision: 1.7.2.2
done
Checking in Bugzilla/Config/MTA.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/MTA.pm,v  <--  MTA.pm
new revision: 1.14.2.1; previous revision: 1.14
done
Checking in template/en/default/admin/params/mta.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/mta.html.tmpl,v  <--  mta.html.tmpl
new revision: 1.9.2.1; previous revision: 1.9
done
Comment 6 Max Kanat-Alexander 2007-08-13 13:20:32 PDT
Added to 3.0 relnotes in bug 391233.

Note You need to log in before you can comment on or make changes to this bug.