Closed Bug 384497 Opened 13 years ago Closed 13 years ago

Add a parameter that enables debug mode for SMTP

Categories

(Bugzilla :: Email Notifications, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: mkanat, Assigned: mkanat)

Details

Attachments

(1 file)

It's really simple to enable Net::SMTP's Debug mode, which prints the whole SMTP transaction to stderr.

Lots of people have various problems in Bugzilla with mail, in 3.0 and before. We get lots of support requests. Thus, I'd like to add this parameter even to the 3.0 branch--it's a pretty trivial change.
Attached patch v1Splinter Review
Here it is! Pretty simple.
Assignee: email-notifications → mkanat
Status: NEW → ASSIGNED
Attachment #268431 - Flags: review?(LpSolit)
Why not turning it on, always? You would only get debug messages on error, not when emails are sent successfully, right? I see no problem filling the error log with debug messages without the agreement of admins.
(In reply to comment #2)
> Why not turning it on, always? You would only get debug messages on error, not
> when emails are sent successfully, right?

  No, you get the messages always. And it's something like 150 lines per message--it'd slow Bugzilla down to a crawl if it was on all the time.
Comment on attachment 268431 [details] [diff] [review]
v1

Looks good but I cannot test it as I don't use SMTP. r=LpSolit assuming you have tested it. I will let you approve it.
Attachment #268431 - Flags: review?(LpSolit) → review+
Flags: approval?
Flags: approval3.0?
Yep, I tested it.

tip:

Checking in Bugzilla/Mailer.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Mailer.pm,v  <--  Mailer.pm
new revision: 1.10; previous revision: 1.9
done
Checking in Bugzilla/Config/MTA.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/MTA.pm,v  <--  MTA.pm
new revision: 1.15; previous revision: 1.14
done
Checking in template/en/default/admin/params/mta.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/mta.html.tmpl,v  <--  mta.html.tmpl
new revision: 1.10; previous revision: 1.9
done


3.0:

Checking in Bugzilla/Mailer.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Mailer.pm,v  <--  Mailer.pm
new revision: 1.7.2.3; previous revision: 1.7.2.2
done
Checking in Bugzilla/Config/MTA.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/MTA.pm,v  <--  MTA.pm
new revision: 1.14.2.1; previous revision: 1.14
done
Checking in template/en/default/admin/params/mta.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/mta.html.tmpl,v  <--  mta.html.tmpl
new revision: 1.9.2.1; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: approval?
Flags: approval3.0?
Flags: approval3.0+
Flags: approval+
Keywords: relnote
Resolution: --- → FIXED
Whiteboard: [relnote 3.0.1]
Added to 3.0 relnotes in bug 391233.
Whiteboard: [relnote 3.0.1]
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.