384608 - Crash Reporter client's buttons are confusing (rename "Close")

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Adam Guthrie]

Attachment: screenshot of dialog

The dialog has two buttons at the bottom: 

- "Close": Closes the Crash Reporter, does not submit the crash report and does not restart Firefox
- "Restart Firefox": Submits the crash report and restart Firefox

I find this behavior confusing. It's like the buttons are trying to accomplish two things are once. There is the "submit crash report or don't submit crash report" choice to be made, as well as the "restart Firefox and don't restart Firefox" choice. If I click "Close" am I closing Firefox or choosing not to submit a report? If I click "Restart Firefox" will I be sending a report and Restarting Firefox, or just restarting Firefox? 

I guess this could be fixed with simply renaming the "Restart Firefox" button to "Submit and Restart Firefox" or something like that, but, to me, trying to coalesce the "submit or don't submit" behavior with "restart or don't restart Firefox" is just confusing.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Actually "Close" submits the crash report as far as I can see.
So as long as you agree to send it it will get sent in any case.
The UI is a bit strange but you can at least submit the crash report without restarting the app.

Comment 2

[Samuel Sidler (old account; do not CC)]

Really, we just need to find a better word for "Close" here. While that's exactly what's being done, there has to be a better way to say it.

(fwiw, I don't like the ordering of the buttons. I think the Close button should be on the right, not the left.)

Comment 3

[(not currently active) Ted Mielczarek]

Obviously they're confusing, since ispiked got them wrong in the initial comment.  :)  We could have the button text change when you tick the "send crash report" box, but that might be confusing.

Comment 4

[Mike Schroepfer]

Windows has two buttons: "Send Error Report" and "Don't Send":

http://www.deez.info/sengelha/blog/wp-content/uploads/2007/04/nullptrcrashdialog.PNG

Which seems much better...

Comment 5

[(not currently active) Ted Mielczarek]

We're offering the option of restarting Firefox as well.  We could make "Restart Firefox" be the checkbox, and then have "send" and "don't send" be the buttons.

Comment 6

[Mike Schroepfer]

(In reply to comment #5)
> We're offering the option of restarting Firefox as well.  We could make
> "Restart Firefox" be the checkbox, and then have "send" and "don't send" be the
> buttons.
> 

Sounds reasonable to me - but I'll differ to Sir Beltzner on this one...

Comment 7

[(not currently active) Ted Mielczarek]

Also, FWIW, the Mac crash reporter looks like this:
http://developer.apple.com/technotes/tn2004/images/tn2123_CrashReporter1.png

The buttons are:
[ Close ]    [ Report... ] [ Reopen ]

So you have to go through an extra step to send the report.

Comment 8

[(not currently active) Ted Mielczarek]

After some discussion, we believe we're going to stick with two buttons, probably:
[  Quit  ]            [  Restart Firefox   ]

But we'll put some text above the buttons to make it clearer, see bug 404855 comment 1.

Comment 9

[(not currently active) Ted Mielczarek]

Fixed.