Closed
Bug 384694
Opened 19 years ago
Closed 18 years ago
Find results (selections) can be hidden by header
Categories
(Other Applications Graveyard :: ChatZilla, defect)
Other Applications Graveyard
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nate, Assigned: bugzilla-mozilla-20000923)
Details
(Whiteboard: [cz-0.9.84])
Attachments
(1 file)
|
5.94 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
Build Identifier:
If I search for something using the find command (Ctrl-F) and set the direction to up, it will find stuff but the found word will be under the URL/Topic section at the top of the screen, making it invisible. You then have to scroll up to see it.
Reproducible: Always
Steps to Reproduce:
1.press Ctrl-F
2.set direction to up
3.type in some text
4.click search
Actual Results:
what I described in the details
Expected Results:
shown the find result in a visible part of the screen
The result of search is under Heading, instead of outside the screen. If to disable Heading (unchecked View|Header) the result is displayed correctly.
| Assignee | ||
Updated•19 years ago
|
Hardware: PC → All
Summary: Find results off of the screen → Find results (selections) can be hidden by header
Comment 2•19 years ago
|
||
Confirmed with ChatZilla 0.9.78.1 [SeaMonkey 2.0a1pre/2007061601]
Comment 3•19 years ago
|
||
Confirmed by Infant with ChatZilla 0.9.78.1-2007060720 [Firefox 3.0a6pre/2007061504]
→ NEW
Status: UNCONFIRMED → NEW
Ever confirmed: true
| Assignee | ||
Comment 4•18 years ago
|
||
I found a subtle bug in the output window code here - hasAttribute was missing "return", so I had to put that in to make the new code work. I also fixed a couple of places that didn't use the wrapper function to use it, now that it works.
Note that, to prevent the view visibly scrolling twice, routeEvent is used to ensure the onFindStart and onFindEnd events are processed synchronously.
The code in getFindData() is quite painful to look at, but it's about the only realistic option we have AFAICT.
Assignee: rginda → silver
Status: NEW → ASSIGNED
Attachment #331145 -
Flags: review?(gijskruitbosch+bugs)
Comment 5•18 years ago
|
||
Comment on attachment 331145 [details] [diff] [review]
Adjust scroll position after find to put selection "inview"
r=me
Silver++ for the find hacks. Please make sure we never need to look at that code again. ;-)
Attachment #331145 -
Flags: review?(gijskruitbosch+bugs) → review+
| Assignee | ||
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.84]
Updated•1 year ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•