384732 - Download manager should use a transaction when importing from downloads.rdf

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Shawn Wilsher :sdwilsh]

We should start a transaction right before we start importing downloads to speed things up (especially with larger downloads.rdf).  This will involve adding one line before this bit http://mxr.mozilla.org/seamonkey/source/toolkit/components/downloads/src/nsDownloadManager.cpp#263
mozStorageTransaction(mDBConn, PR_TRUE);

and of course, #include "mozStorageHelper.h" somewhere up top :)

Comment 1

[Ed Lee :Mardak]

Attachment: v1

(void) the mozStorageTransaction return value from mozStorageTransaction's constructor

(void) the PRInt64 return value from AddDownloadToDB

Comment 2

[Ed Lee :Mardak]

Attachment: v2

on second though, a constructor has no return value.. there's no return statements.....

(However, I suppose a new <class> would have a return type of <class>.)

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 268660 [details] [diff] [review]
v2


>+  // Use a transaction to speed up INSERTs if we happen to be adding
>+  // a lot of downloads - commits the transaction when destructing.
nit: lose the comment - it is what the function is for.

Comment 4

[Ed Lee :Mardak]

Attachment: v3

(In reply to comment #3)
> >+  // Use a transaction to speed up INSERTs if we happen to be adding
> >+  // a lot of downloads - commits the transaction when destructing.
> nit: lose the comment - it is what the function is for.
gone

Comment 5

[Shawn Wilsher :sdwilsh]

actually - does this even compile?  It should be something like:
mozStorageTransaction transaction(mDBConn, PR_TRUE);

Sorry for the confusing initial comment....

Comment 6

[Ed Lee :Mardak]

It compiles. I looked through other code and they do something similar. That's why I originally put the comments about how the constructor/destructor works.

Without a name, it'll still construct a mozStorageTransaction object for the scope and it'll destruct at the end of the method.

Comment 7

[Ed Lee :Mardak]

Attachment: v4

Oops, it /does/ compile but apparently without a name, it constructs and destructs on that same line.

Comment 8

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.90; previous revision: 1.89