384733 - "Add Bookmark" dialog truncated if you have "bookmarkPropertiesDialog/lastUsed" annotations that point to itemIds for folder that don't exist

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070615 Minefield/3.0a6pre

Summary: "Add Bookmark" dialog truncated/incorrectly sized (sizeToContent?)

Steps to Reproduce:

1. Click "Bookmarks" then "Bookmark This Page"
2. Look at the resulting "Add Bookmark" dialog

Expected Results:

"Add Bookmark" dialog is sized correctly using sizeToContent()

Actual Results:

"Add Bookmark" dialog (see screenshot) is sized only to its dialog title and close widget

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of the Add Bookmark dialog

I forgot to also note that this dialog IS resizable, however, it doesn't ever appear to remember its last size.

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

I have seen this same thing, and deleting file: places.sqlite fixed the bookmark dialog box, but the downside of that is you have to re-do your bookmarks, and you lose your History.  

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070616 Minefield/3.0a6pre Firefox/3.0 ID:2007061615

Comment 3

[(not reading, please use [e-mail] instead)]

the screen shot sort of resembles bug #380232, but dietrich already fixed that.

stephen / jim:  anything showing in your error console?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> the screen shot sort of resembles bug #380232, but dietrich already fixed that.
> 
> stephen / jim:  anything showing in your error console?

Just what I filed in bug 384731, but I think that's unrelated?

Comment 5

[(not reading, please use [e-mail] instead)]

> Just what I filed in bug 384731, but I think that's unrelated?

I think it is related, but I'll confirm that.

I just ran into this with "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070620 Minefield/3.0a6pre" on a particular page. 

Investigating.

Comment 6

[(not reading, please use [e-mail] instead)]

Are you able to reproduce at will?

Any idea if you might be hitting bug #385490?

once bug #384731 and #385490 are fixed, can you try again and report if you see an assertion?

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #6)
> Are you able to reproduce at will?

Yes: every time I bookmark, this occurs.

 
> Any idea if you might be hitting bug #385490?

Yup; hitting that 100%
 
> once bug #384731 and #385490 are fixed, can you try again and report if you see
> an assertion?

Will do! 

Comment 8

[(not reading, please use [e-mail] instead)]

>> Are you able to reproduce at will?
> Yes: every time I bookmark, this occurs.

if you are hitting it every time you bookmark, my guess is you have some stale bookmarkPropertiesDialog/lastUsed annotation.  (or worse?)  can you share your places.sqlite file privately over email?

Comment 9

[(not reading, please use [e-mail] instead)]

stephen shared his places.sqlite, and I can see that he has some stale annotations.  I'm not sure if the folder in question was removed before bug #375629 or not.

The patch for bug #384731 fixes this problem, and he does assert (screen shot coming).

He's got a bookmarkPropertiesDialog/lastUsed annotation that points to item_id 0, which doesn't exist in his places.sqlite file.  I'm not sure how he ended up in that state, though.

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of the assert a tester would see if they have a stale annotation

Comment 11

[(not reading, please use [e-mail] instead)]

fixed by checkin for bug #384731

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070622 Minefield/3.0a6pre, which I grabbed as firefox-3.0a6pre.en-US.win32.installer.exe  	6128 KB  	6/23/2007  	4:09:00 AM from ftp://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/fx-win32-tbox-trunk/

Verified FIXED using my steps from comment 0; although I now see the assertion Seth referenced above in comment 10 (https://bugzilla.mozilla.org/attachment.cgi?id=269418), the Add Bookmark dialog is correctly sized and I tested that adding bookmarks (still) works as expected.

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv