Closed Bug 384746 Opened 17 years ago Closed 16 years ago

Win64 build support for mozilla/toolkit

Categories

(Toolkit :: Startup and Profile System, defect)

Product:
Toolkit
Component:
Startup and Profile System
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file, 2 obsolete files)

patch v3
3.40 KB, patch
neil
: review+
benjamin
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
Build Identifier: 

Since DDE definition is obsolute, current toolkit code isn't compatible for Win64 build.

Reproducible: Always
Attached patch a Win64 patch for toolkit (obsolete) — — Splinter Review 

        Attachment #268656 -
        Flags: review?

    
    

    
  
Comment on attachment 268656 [details] [diff] [review]
a Win64 patch for toolkit

Using a reinterpret cast on a function pointer is evil; don't ever do it.  Fix the signature properly.  (The correct signature is at http://msdn2.microsoft.com/en-us/library/ms648742.aspx)

Also, you have to request review from a person; setting the review flag by itself does nothing useful.  An appropriate reviewer might be neil@httl.net

        Attachment #268656 -
        Flags: review? → review-

    
  
Assignee: nobody → m_kato

    
  
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        a patch v2 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #268656 -
        Attachment is obsolete: true

    
  
Component: XRE Startup → Startup and Profile System
QA Contact: xre.startup → startup

    
  
Blocks: tracking_win64

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v3
        — 
          — Splinter Review
      

    


  

        Attachment #323552 -
        Attachment is obsolete: true

        Attachment #354955 -
        Flags: review?(neil)

    
  

        Attachment #354955 -
        Flags: review?(neil) → review+

    
  

        Attachment #354955 -
        Flags: superreview?(benjamin)

    
  

        Attachment #354955 -
        Flags: superreview?(benjamin) → superreview+

    
    

    
  
checked in
http://hg.mozilla.org/mozilla-central/rev/dda0e6c28112
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: