Closed Bug 384762 Opened 18 years ago Closed 18 years ago

Negative margin + clear broken

Categories

(Core :: Layout: Floats, defect)

Product:
Core
Component:
Layout: Floats
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: sharparrow1, Assigned: sharparrow1)

References

(
URL
)

Details

(Keywords: regression, testcase)

Attachments

(1 file)

Patch
2.88 KB, patch
dbaron
: review+
dbaron
: superreview+
Details | Diff | Splinter Review
data:text/html,<div style="margin-top: -10em; clear:both">a The "a" shouldn't be visible, but it is on trunk. I'm pretty sure this is caused by the patch to bug 349113 by code inspection; I haven't actually tested, though. The issue is that mMaximalLeftYMost/mMaximalRightYMost should be initialized to nscoord_MIN, not zero.
Flags: in-testsuite?
Keywords: regression, testcase
OS: Windows XP → All
Hardware: PC → All
Assignee: nobody → sharparrow1
Attached patch Patch — — Splinter Review
Patch per comment 0.
Attachment #269880 - Flags: review?(dbaron)
Status: NEW → ASSIGNED
Flags: blocking1.9? → blocking1.9+
Comment on attachment 269880 [details] [diff] [review] Patch r+sr=dbaron
Attachment #269880 - Flags: superreview+
Attachment #269880 - Flags: review?(dbaron)
Attachment #269880 - Flags: review+
... but please add the testcase to the reftests in layout/reftests/bugs/.
Oh, nice catch. Sorry about that.
Checked in with reftest.
Flags: in-testsuite? → in-testsuite+
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: