Closed
Bug 384856
Opened 18 years ago
Closed 18 years ago
Replace illegal characters for downloads more consistently (use _ not -)
Categories
(Core Graveyard :: File Handling, defect)
Core Graveyard
File Handling
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha6
People
(Reporter: Mardak, Assigned: Mardak)
Details
Attachments
(1 file)
|
1.31 KB,
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
|
Details | Diff | Splinter Review |
Bug 314846 #c4
saveURL (alt-click, save as) replaces some illegal characters with underscore (_), but exthandler replaces all of them with dash (-)
This applies to windows, mac, unix (but windows has some other special characters)
http://mxr.mozilla.org/mozilla/source/toolkit/content/contentAreaUtils.js#808
Attachment #268762 -
Flags: review?
|
||
Comment 1•18 years ago
|
||
I think biesi would be the man for your r/sr here.
|
||
Updated•18 years ago
|
Attachment #268762 -
Flags: review? → review+
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [checkin needed]
|
||
Comment 2•18 years ago
|
||
does this still need sr?
|
|
||
Updated•18 years ago
|
Attachment #268762 -
Flags: superreview+
|
||
Comment 3•18 years ago
|
||
Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v <-- nsExternalHelperAppService.cpp
new revision: 1.313; previous revision: 1.312
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
|
|
||
Updated•18 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9alpha6
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•