Closed Bug 384856 Opened 16 years ago Closed 16 years ago

Replace illegal characters for downloads more consistently (use _ not -)

Categories

(Core Graveyard :: File Handling, defect)

Product:
Core Graveyard
Component:
File Handling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha6

People

(Reporter: Mardak, Assigned: Mardak)

Details

Attachments

(1 file)

v1
1.31 KB, patch
Biesinger
: review+
Biesinger
: superreview+
Details | Diff | Splinter Review
Attached patch v1 — — Splinter Review 
Bug 314846 #c4

saveURL (alt-click, save as) replaces some illegal characters with underscore (_), but exthandler replaces all of them with dash (-)

This applies to windows, mac, unix (but windows has some other special characters)

http://mxr.mozilla.org/mozilla/source/toolkit/content/contentAreaUtils.js#808
Attachment #268762 - Flags: review?
I think biesi would be the man for your r/sr here.
Whiteboard: [checkin needed]
does this still need sr?
Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <--  nsExternalHelperAppService.cpp
new revision: 1.313; previous revision: 1.312
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9alpha6
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.