Investigate eliminating the LL_* macros from nsDownloadManager.cpp

VERIFIED FIXED in mozilla1.9alpha6

Status

()

Toolkit
Downloads API
--
minor
VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: sciguyryan, Assigned: sciguyryan)

Tracking

Trunk
mozilla1.9alpha6
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

11 years ago
See bug 384867 comment 2 and up.
(Assignee)

Updated

11 years ago
Assignee: nobody → sciguyryan
(Assignee)

Comment 1

11 years ago
Created attachment 268827 [details] [diff] [review]
Patch v1.0

Patch v1.0

Like so?
Attachment #268827 - Flags: review?(sdwilsh)
Comment on attachment 268827 [details] [diff] [review]
Patch v1.0

>+  if ((mStartTime == 0) && (aStateFlags & STATE_START))
nit: we don't use the () around things anywhere else (in regards to mStartTime check)
Attachment #268827 - Flags: review?(sdwilsh) → review+
(Assignee)

Comment 3

11 years ago
Created attachment 268828 [details] [diff] [review]
Patch v1.1

Patch v1.1
Attachment #268827 - Attachment is obsolete: true
Attachment #268828 - Flags: review?(sdwilsh)
(Assignee)

Updated

11 years ago
Attachment #268828 - Flags: review?(sdwilsh)
Comment on attachment 268828 [details] [diff] [review]
Patch v1.1

yes yes, just fix my last nit too :p
Attachment #268828 - Flags: review+
(Assignee)

Comment 5

11 years ago
Created attachment 268830 [details] [diff] [review]
For checkin

Patch v1.2

Nits be gone!
Attachment #268828 - Attachment is obsolete: true
(Assignee)

Updated

11 years ago
Whiteboard: [checkin needed]
Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.89; previous revision: 1.88
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]

Updated

11 years ago
Target Milestone: --- → Firefox 3 alpha6
Flags: in-testsuite-
Verified FIXED using Bonsai for code inspection:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsDownloadManager.cpp&branch=&root=/cvsroot&subdir=mozilla/toolkit/components/downloads/src&command=DIFF_FRAMESET&rev1=1.88&rev2=1.89
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.