Closed Bug 384892 Opened 17 years ago Closed 17 years ago

Investigate eliminating the LL_* macros from nsDownloadManager.cpp

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9alpha6

People

(Reporter: sciguyryan, Assigned: sciguyryan)

Details

Attachments

(1 file, 2 obsolete files)

For checkin
2.99 KB, patch
Details | Diff | Splinter Review
Assignee: nobody → sciguyryan
Attached patch Patch v1.0 (obsolete) — — Splinter Review 
Patch v1.0

Like so?
Attachment #268827 - Flags: review?(sdwilsh)
Comment on attachment 268827 [details] [diff] [review]
Patch v1.0

>+  if ((mStartTime == 0) && (aStateFlags & STATE_START))
nit: we don't use the () around things anywhere else (in regards to mStartTime check)
Attachment #268827 - Flags: review?(sdwilsh) → review+
Attached patch Patch v1.1 (obsolete) — — Splinter Review 
Patch v1.1
Attachment #268827 - Attachment is obsolete: true
Attachment #268828 - Flags: review?(sdwilsh)
Attachment #268828 - Flags: review?(sdwilsh)
Comment on attachment 268828 [details] [diff] [review]
Patch v1.1

yes yes, just fix my last nit too :p
Attachment #268828 - Flags: review+
Attached patch For checkin — — Splinter Review 
Patch v1.2

Nits be gone!
Attachment #268828 - Attachment is obsolete: true
Whiteboard: [checkin needed]
Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.89; previous revision: 1.88
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 3 alpha6
Flags: in-testsuite-
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: