Closed Bug 384936 Opened 17 years ago Closed 17 years ago

Folders in bookmarks menu are inaccessible after moving a bookmark to/in the menu

Categories

(Firefox :: Bookmarks & History, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 3 alpha6

People

(Reporter: Eriatile, Assigned: asaf)

Details

(Keywords: regression)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070618 Minefield/3.0a6pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070618 Minefield/3.0a6pre

Moving a bookmark inside the bookmark menu make folders (possibly only those with subfolder) inaccessible.
Restarting firefox solve the problem.

Reproducible: Always

Steps to Reproduce:
1. Move a bookmark inside the bookmarks menu (or drag one in)
2. Try to access a folder inside the bookmarks menu
Actual Results:  
Folders inside the bookmarks menu are inaccessible.

Expected Results:  
Folders should still be accesssible without restarting firefox.
Attached patch Don't rebuildSplinter Review
the view implementation takes care of updating the dom nodes.
Assignee: nobody → mano
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #268848 - Flags: review?(dietrich)
Comment on attachment 268848 [details] [diff] [review]
Don't rebuild

r=sspitzer
Attachment #268848 - Flags: review?(dietrich) → review+
mozilla/browser/components/places/content/menu.xml 1.76
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: regression
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 alpha6
The problem appears again in 2007062504 build. Beside :
- move a bookmark from bookmarks bar inside bookmarks menu
- try to access folders from menu : you can't
- restart firefox : bookmarks bar is empty and you get an assert error
- restart firefox again, everything is back to normal

I filled bug 385812 (moving a folder inside bookmarks bar make it inaccessible) which I think is related to this one and bug 381751.
Component: Bookmarks → Places
QA Contact: bookmarks → places
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: