384942 - dump graph on cycle collection fault

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Graydon Hoare :graydon]

Attachment: patch to write out a graph highlighting the offending node on a fatal fault

When the cycle collector hits a fatal fault (in a DEBUG build, with DEBUG_CC defined at compile time and XPCOM_CC_FAULT_IS_FATAL at runtime), it's nice to get a dump of the current collection graph with the offending node highlighted.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 268850 [details] [diff] [review]
patch to write out a graph highlighting the offending node on a fatal fault

Looks good, but 2 thoughts:
 * why not just set sCurrGraph in GCGraph's ctor and dtor?
 * seems like it would be useful even if faults aren't fatal

r=dbaron

Comment 2

[Graydon Hoare :graydon]

Checked in with fix to use GCGraph ctor/dtor. 

It's easy enough to toggle fatality at runtime, and I'd imagine if you have DEBUG on you won't notice a CC fault amongst all the debug chatter.

new revision: 1.51; previous revision: 1.50