384989 - disable new bookmark / new live bookmark when excludeItems is set

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

disable new bookmark / new live bookmark when excludeItems is set

spun off from bug #383681, per mano

note, File | New Live Bookmark should be disabled as well.

Comment 1

[Christine Yen]

Attachment: patch

Depends on nodeExcludesItems() in utils.js, in the patch for bug 387035

Comment 2

[Asaf Romano (gone)]

hrm, I don't think this is right for live bookmarks actually... these are visible in exculdeItems queries.

Comment 3

[Christine Yen]

Attachment: patch

(In reply to comment #2)
> hrm, I don't think this is right for live bookmarks actually... these are
> visible in exculdeItems queries.

Makes sense, you're right.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 271918 [details] [diff] [review]
patch

Oh well, just make this
this._view.getResult().root.queryOptions.excludeItems

And please remove the asQuery wrapping in the separator case, GetRoot returns the container as a query a object.

Comment 5

[Christine Yen]

Attachment: revision

Comment 6

[Asaf Romano (gone)]

Comment on attachment 271925 [details] [diff] [review]
revision

r=mano

Comment 7

[(not reading, please use [e-mail] instead)]

Are we sure we want to disable these commands when excludeItems is set?

Unlike separators (see bug #383681), no matter what the sort is on the right hand pane, adding a new livemark / new bookmark, still makes sense right?

It seems that disabling the commands just because a folder in the left hand pane has focus may not be correct.  (How would an end user know that they right hand pane needs focus for those commands to work?)

Additionally, what would that mean for paste when the left hand pane has focus?

asaf / cyen, what do you think?

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 271925 [details] [diff] [review]
revision

Also, what did fx 2 do?

Comment 9

[(not reading, please use [e-mail] instead)]

> Also, what did fx 2 do?

For fx 2, new bookmark, new folder, and new live bookmark are all enabled.

I think we should WONTFIX this bug.

cyen, what do you think?

Comment 10

[Christine Yen]

(In reply to comment #9)
> > Also, what did fx 2 do?
> 
> For fx 2, new bookmark, new folder, and new live bookmark are all enabled.
> 
> I think we should WONTFIX this bug.
> 
> cyen, what do you think?
> 

I think... with the patch for bug 387035, inserting with anything in the left panel selected will insert the item correctly into the bottom of the folder's contents, in the right pane - and the problematic "my-new-item-isn't-showing-up-where-it's-supposed-to" behavior in bugs like bug 383681 will no longer be a problem.

Actually - I sort of want to enable separators if excludeItems = true, too, for the sake of consistency.

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv