disable new bookmark / new live bookmark when excludeItems is set

RESOLVED WONTFIX

Status

()

Firefox
Bookmarks & History
RESOLVED WONTFIX
11 years ago
9 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: Christine Yen)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

disable new bookmark / new live bookmark when excludeItems is set

spun off from bug #383681, per mano

note, File | New Live Bookmark should be disabled as well.
Depends on: 383681
(Assignee)

Updated

11 years ago
Assignee: nobody → cyen
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
Depends on: 387035
(Assignee)

Comment 1

11 years ago
Created attachment 271914 [details] [diff] [review]
patch

Depends on nodeExcludesItems() in utils.js, in the patch for bug 387035
Attachment #271914 - Flags: review?(sspitzer)
hrm, I don't think this is right for live bookmarks actually... these are visible in exculdeItems queries.
(Assignee)

Comment 3

11 years ago
Created attachment 271918 [details] [diff] [review]
patch

(In reply to comment #2)
> hrm, I don't think this is right for live bookmarks actually... these are
> visible in exculdeItems queries.

Makes sense, you're right.
Attachment #271914 - Attachment is obsolete: true
Attachment #271918 - Flags: review?(mano)
Comment on attachment 271918 [details] [diff] [review]
patch

Oh well, just make this
this._view.getResult().root.queryOptions.excludeItems

And please remove the asQuery wrapping in the separator case, GetRoot returns the container as a query a object.
Attachment #271918 - Flags: review?(mano)
(Assignee)

Comment 5

11 years ago
Created attachment 271925 [details] [diff] [review]
revision
Attachment #271918 - Attachment is obsolete: true
Attachment #271925 - Flags: review?
(Assignee)

Updated

11 years ago
No longer depends on: 387035
Are we sure we want to disable these commands when excludeItems is set?

Unlike separators (see bug #383681), no matter what the sort is on the right hand pane, adding a new livemark / new bookmark, still makes sense right?

It seems that disabling the commands just because a folder in the left hand pane has focus may not be correct.  (How would an end user know that they right hand pane needs focus for those commands to work?)

Additionally, what would that mean for paste when the left hand pane has focus?

asaf / cyen, what do you think?
Comment on attachment 271925 [details] [diff] [review]
revision

Also, what did fx 2 do?
Attachment #271925 - Flags: ui-review?(beltzner)
> Also, what did fx 2 do?

For fx 2, new bookmark, new folder, and new live bookmark are all enabled.

I think we should WONTFIX this bug.

cyen, what do you think?
(Assignee)

Comment 10

11 years ago
(In reply to comment #9)
> > Also, what did fx 2 do?
> 
> For fx 2, new bookmark, new folder, and new live bookmark are all enabled.
> 
> I think we should WONTFIX this bug.
> 
> cyen, what do you think?
> 

I think... with the patch for bug 387035, inserting with anything in the left panel selected will insert the item correctly into the bottom of the folder's contents, in the right pane - and the problematic "my-new-item-isn't-showing-up-where-it's-supposed-to" behavior in bugs like bug 383681 will no longer be a problem.

Actually - I sort of want to enable separators if excludeItems = true, too, for the sake of consistency.
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
Attachment #271925 - Flags: ui-review?(beltzner)
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.