385056 - Remove MOZ_XUL_APP ifdefs from /mailnews

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: Tidy l10n files.

Now that SeaMonkey is an XUL app, we can tidy up the MOZ_XUL_APP ifdefs in /mailnews.

First patch I'm attaching deals with the l10n stuff, second will deal with the main code.

Comment 1

[Mark Banner (:standard8)]

Attachment: Removals from the main code.

Comment 2

[Worcester12345]

"footprint" key word?

Comment 3

[Robert Kaiser]

Worcester12345:
No, as it's not changing the code that is actually built, it just removes code that is not even built. "footprint" is about changes in memory footprint of the running app, but this doesn't affect the running app at all.

Comment 4

[Robert Kaiser]

Comment on attachment 268971 [details] [diff] [review]
Tidy l10n files.

looks good and builds correctly, thanks for doing that. r=me

Comment 5

[Scott MacGregor]

Comment on attachment 268973 [details] [diff] [review]
Removals from the main code.

cool!

Comment 6

[Worcester12345]

Maybe I was thinking of this:
Bug 171082 – Do everything possible to minimize the build size

as a blocker.

Comment 7

[Robert Kaiser]

Worcester12345:
1) I repeat, this does _not_ impact build size. Not a bit. It only affects size of the code before building, but we are cleaning out code that _does not_ end up in the build at all nowadays.
2) The other bug is probably no relevant bug report, as it is too vague and can never be marked FIXED by that summary.

Comment 8

[Mark Banner (:standard8)]

Both patches checked in -> fixed.