385073 - Pass only the nsIAbDirectory derived object when opening ldap directory properites dialog.

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

Attachment: Patch v1

Currently when we open a LDAP directory properties dialog, we require both the directory name and the base pref name to be passed to the xul window via the args.

If we pass just a nsIAbDirectory class (of type nsIAbLDAPDirectory, of course), then we can use this to simplify some of the LDAP directory properties code.

I'm also intending this as the first of a string of changes to eventually remove some of the ldap specific code from the "core" address book stuff, and therefore to make it easier for different address book types to bring up different properties dialogs (e.g. for our own address books and for extensions).

Comment 1

[David :Bienvenu]

Comment on attachment 268981 [details] [diff] [review]
Patch v1

+  document.getElementById("port").value =
+    
looks good - one nit: this formatting is odd. Either the last line should be indented a little, or (and I know Neil hates this) do something like this:

a = (conditional) ? foo
                  : bar;

To me, that's more readable. Or,

a = (cond) ? foo :
             bar;




document.getElementById("secure").checked ? kDefaultSecureLDAPPort :
+    kDefaultLDAPPort;

Comment 2

[Mark Banner (:standard8)]

Patch checked in -> fixed.