Closed
Bug 385091
Opened 17 years ago
Closed 17 years ago
Windows SDK package needed
Categories
(Directory :: LDAP C SDK, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: richm, Assigned: mcs)
References
Details
Attachments
(3 files)
13.67 KB,
patch
|
mcs
:
review+
|
Details | Diff | Splinter Review |
1.31 KB,
text/plain
|
Details | |
3.69 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
We need to be able to build an SDK package for windows, that can be built with VC Express Edition 8.0.
Reporter | ||
Comment 1•17 years ago
|
||
1) Update the packaging Makefile (package.mk) for Windows and SASL. 2) Add support for manifests in VC 8.0. There is a new command line tool called mt.exe that is used to generate manifest files and to compile them into the executables. This allows ldapsearch.exe to be able to find the right msvcr80.dll at runtime. This was copied from NSS at Nelson's suggestion. 3) Added support for being able to do a configure and make in a different directory. I find it very useful to be able to create a "build" directory and run configure like this: cd ~/build /path/to/mozilla/directory/c-sdk/configure ... args ... make Then I can just completely blow away the build directory if I need to. I know this is what make clean/make clobber are supposed to do, but keeping the binary and source directories separate like this also facilitates creating source tarballs from the working directory for use in building rpms/packages. There were a few changes required to cygwin_wrapper and the makefiles to support building in this manner.
Attachment #268990 -
Flags: review?(mcs)
Assignee | ||
Comment 2•17 years ago
|
||
Comment on attachment 268990 [details] [diff] [review] diffs I do not know a lot about manifest files, but these changes look OK to me.
Attachment #268990 -
Flags: review?(mcs) → review+
Reporter | ||
Comment 3•17 years ago
|
||
Thanks Mark.
Reporter | ||
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 4•17 years ago
|
||
I had to back this patch out of the LDAPCSDK_6_0_3_CLIENT_BRANCH as it was causing problems for various compilers on Windows when compiling SeaMonkey/Thunderbird. ======= making ./nsldap32v60.dll sh /d/moz/mozilla/directory/c-sdk/config/cygwin-wrapper link -OPT:REF -nologo -MAP -DLL -PDB:NONE -SUBSYSTEM:CONSOLE wsock32.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib rpcrt4.lib uuid.lib winmm.lib d:/moz/mozilla/obj-suite/dist/lib/nsldif32v60.lib d:/moz/mozilla/obj-suite/dist/lib/nslber32v60.lib -out:"nsldap32v60.dll" ./abandon.obj ./add.obj ./authzidctrl.obj ./bind.obj ./cache.obj ./charray.obj ./charset.obj ./compare.obj ./compat.obj ./control.obj ./countvalues.obj ./delete.obj ./disptmpl.obj ./dsparse.obj ./error.obj ./extendop.obj ./free.obj ./freevalues.obj ./friendly.obj ./getattr.obj ./getdn.obj ./getdxbyname.obj ./geteffectiverightsctrl.obj ./getentry.obj ./getfilter.obj ./getoption.obj ./getvalues.obj ./memcache.obj ./message.obj ./modify.obj ./open.obj ./os-ip.obj ./proxyauthctrl.obj ./psearch.obj ./pwmodext.obj ./pwpctrl.obj ./referral.obj ./regex.obj ./rename.obj ./request.obj ./reslist.obj ./result.obj ./saslbind.obj ./sbind.obj ./search.obj ./setoption.obj ./sort.obj ./sortctrl.obj ./srchpref.obj ./tmplout.obj ./ufn.obj ./unbind.obj ./unescape.obj ./url.obj ./userstatusctrl.obj ./utf8.obj ./vlistctrl.obj ./whoami.obj ./dllmain.obj ./mozock.obj -DEF:/d/moz/mozilla/directory/c-sdk/ldap/libraries/libldap/../msdos/winsock/nsldap32.def wsock32.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib rpcrt4.lib uuid.lib winmm.lib d:/moz/mozilla/obj-suite/dist/lib/nsldif32v60.lib d:/moz/mozilla/obj-suite/dist/lib/nslber32v60.lib /d/moz/mozilla/directory/c-sdk/config/cygwin-wrapper: cygpath: command not found LINK : fatal error LNK1146: no argument specified with option '/DEF:' make: *** [nsldap32v60.dll] Error 122 Neil fixed this with the patch I'll attach in a moment, but I've got no idea whether or not its the correct thing to do, or if it'll work with the tinderboxes.
Comment 5•17 years ago
|
||
Reporter | ||
Comment 6•17 years ago
|
||
The patch removes CYGWIN_WRAPPER? And why is cygpath not found? Is it possible to have a cygwin installation without the cygpath command?
Comment 7•17 years ago
|
||
(In reply to comment #6) >The patch removes CYGWIN_WRAPPER? CYGWIN_WRAPPER is set correctly for cygwin (and not MSYS) earlier in configure. >And why is cygpath not found? >Is it possible to have a cygwin installation without the cygpath command? It's not a cygwin installation. The MozillaBuild package uses MSYS which has neither cygpath nor cygwin_wrapper. http://developer.mozilla.org/en/docs/Windows_Build_Prerequisites
Updated•16 years ago
|
Attachment #271445 -
Flags: review?(richm)
Comment 8•16 years ago
|
||
Comment on attachment 271445 [details] [diff] [review] Neil's fix. Rich, could you take another look at this please (see also Neil's response in comment 7). I'm getting round to looking at upgrading Thunderbird's usage of the LDAP c-sdk to the latest again, and I've just had it verified that we still need this patch to be able to build the latest.
Reporter | ||
Comment 9•16 years ago
|
||
Ok. Looks good. BTW, has anyone tried building the mozldap c-sdk standalone with msys? msys looks like a much better environment for builds than cygwin, much more lightweight, and fully supported by the MozillaBuild package.
Comment 10•16 years ago
|
||
Comment on attachment 271445 [details] [diff] [review] Neil's fix. I've checked this in after Rich's ok in comment 9. Checking in ldap/libraries/libldap/Makefile.in; /cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldap/Makefile.in,v <-- Makefile.in new revision: 5.24; previous revision: 5.23 done Checking in configure; /cvsroot/mozilla/directory/c-sdk/configure,v <-- configure new revision: 5.70; previous revision: 5.69 done Checking in configure.in; /cvsroot/mozilla/directory/c-sdk/configure.in,v <-- configure.in new revision: 5.64; previous revision: 5.63 done Checking in ldap/libraries/libldif/Makefile.in; /cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldif/Makefile.in,v <-- Makefile.in new revision: 5.10; previous revision: 5.9 done Checking in ldap/libraries/libprldap/Makefile.in; /cvsroot/mozilla/directory/c-sdk/ldap/libraries/libprldap/Makefile.in,v <-- Makefile.in new revision: 5.19; previous revision: 5.18 done Checking in ldap/libraries/libssldap/Makefile.in; /cvsroot/mozilla/directory/c-sdk/ldap/libraries/libssldap/Makefile.in,v <-- Makefile.in new revision: 5.16; previous revision: 5.15 done
Attachment #271445 -
Flags: review?(richm) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•