385241 - Disable libxul for debug builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Stuart Parmenter]

Per the conversation at the 1.9 meeting a week ago

Comment 1

[Stuart Parmenter]

Benjamin, can you please put a patch together for this?  I've looked over configure.in but don't see what needs to be done.

Comment 2

[Benjamin Smedberg]

This is low-priority for me right now, especially given the easy workaround of specifying --disable-libxul. Meta-flags are really hard to get right.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: trivial fix

This is pretty much the simplest fix possible.

Comment 4

[Benjamin Smedberg]

Comment on attachment 269851 [details] [diff] [review]
trivial fix

I'm pretty sure this doesn't work right for the case where you want debug+libxul. You at least need to move this check above the --enable-libxul check (so that it operates on the default value and not the commandline-specified value).

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: as suggested

This puts that check right before the enable-libxul check, so it should only override the default value.

Comment 6

[Benjamin Smedberg]

Comment on attachment 269855 [details] [diff] [review]
as suggested

Please test, but this looks ok.

Comment 7

[(not currently active) Ted Mielczarek]

Sorry, just got around to testing this, it WFM.  Checked in.

Comment 8

[Alex Vincent [:WeirdAl]]

So this is why my XULRunner debug build started crashing all the time...

http://developer.mozilla.org/en/docs/mozilla.dev.platform_FAQ

It would have been nice to have a configure.in check for XULRunner debug builds without libxul.

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #8)

XULRunner without libxul is a perfectly valid configuration. Trying to relink libxul every time you make a small change in C++ really blows.

You just need to set some env variables (PATH or LD_LIBRARY_PATH set to point to the xulrunner directory, iirc) so that your linker can find everything.