Closed Bug 385241 Opened 14 years ago Closed 14 years ago
Disable libxul for debug builds
Per the conversation at the 1.9 meeting a week ago
Benjamin, can you please put a patch together for this? I've looked over configure.in but don't see what needs to be done.
This is low-priority for me right now, especially given the easy workaround of specifying --disable-libxul. Meta-flags are really hard to get right.
This is pretty much the simplest fix possible.
Assignee: benjamin → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #269851 - Flags: review?(benjamin)
Comment on attachment 269851 [details] [diff] [review] trivial fix I'm pretty sure this doesn't work right for the case where you want debug+libxul. You at least need to move this check above the --enable-libxul check (so that it operates on the default value and not the commandline-specified value).
Attachment #269851 - Flags: review?(benjamin) → review-
This puts that check right before the enable-libxul check, so it should only override the default value.
Comment on attachment 269855 [details] [diff] [review] as suggested Please test, but this looks ok.
Attachment #269855 - Flags: review?(benjamin) → review+
Sorry, just got around to testing this, it WFM. Checked in.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
So this is why my XULRunner debug build started crashing all the time... http://developer.mozilla.org/en/docs/mozilla.dev.platform_FAQ It would have been nice to have a configure.in check for XULRunner debug builds without libxul.
(In reply to comment #8) XULRunner without libxul is a perfectly valid configuration. Trying to relink libxul every time you make a small change in C++ really blows. You just need to set some env variables (PATH or LD_LIBRARY_PATH set to point to the xulrunner directory, iirc) so that your linker can find everything.
You need to log in before you can comment on or make changes to this bug.