Closed Bug 385241 Opened 15 years ago Closed 15 years ago

Disable libxul for debug builds


(Firefox Build System :: General, defect)

Not set


(Not tracked)



(Reporter: pavlov, Assigned: ted)




(1 file, 1 obsolete file)

Per the conversation at the 1.9 meeting a week ago
Benjamin, can you please put a patch together for this?  I've looked over but don't see what needs to be done.
This is low-priority for me right now, especially given the easy workaround of specifying --disable-libxul. Meta-flags are really hard to get right.
Attached patch trivial fix (obsolete) — Splinter Review
This is pretty much the simplest fix possible.
Assignee: benjamin → ted.mielczarek
Attachment #269851 - Flags: review?(benjamin)
Comment on attachment 269851 [details] [diff] [review]
trivial fix

I'm pretty sure this doesn't work right for the case where you want debug+libxul. You at least need to move this check above the --enable-libxul check (so that it operates on the default value and not the commandline-specified value).
Attachment #269851 - Flags: review?(benjamin) → review-
Attached patch as suggestedSplinter Review
This puts that check right before the enable-libxul check, so it should only override the default value.
Attachment #269851 - Attachment is obsolete: true
Attachment #269855 - Flags: review?(benjamin)
Comment on attachment 269855 [details] [diff] [review]
as suggested

Please test, but this looks ok.
Attachment #269855 - Flags: review?(benjamin) → review+
Sorry, just got around to testing this, it WFM.  Checked in.
Closed: 15 years ago
Resolution: --- → FIXED
So this is why my XULRunner debug build started crashing all the time...

It would have been nice to have a check for XULRunner debug builds without libxul.
(In reply to comment #8)

XULRunner without libxul is a perfectly valid configuration. Trying to relink libxul every time you make a small change in C++ really blows.

You just need to set some env variables (PATH or LD_LIBRARY_PATH set to point to the xulrunner directory, iirc) so that your linker can find everything.
Blocks: 395586
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.