385347 - when I mouse over certain .dlls, I get a tooltip claiming the company is "Netscape Communications Corporation"

Status: RESOLVED WORKSFORME

(Core :: General, defect)

Description

[(not reading, please use [e-mail] instead)]

when I mouse over certain .dlls, I get a tooltip claiming the company is "Netscape Communications Corporation"

/js/jsd/jsd3240.rc, line 77 -- VALUE "FileDescription", "Netscape 32-bit JavaScript Debugger Module\0"
/js/src/js3240.rc, line 38 -- VALUE "FileDescription", "Netscape 32-bit JavaScript Module\0"

wtc:  It looks like nspr4.dll and plc4.dll and plds4.dll do the same thing.

bsmedberg:  for xul.dll, I don't see any company info at all.

For the rest of the dlls, I see "Mozilla Foundation"

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[Wan-Teh Chang]

We fixed this bug for the NSS DLLs in bug 326403.  Somehow we
forgot to fix the NSPR and JSS DLLs.

Our fix was to change "CompanyName" to "Mozilla Foundation\0"
and remove the optional "LegalCopyright".

Comment 3

[Wan-Teh Chang]

Attachment: NSPR patch

Seth, could you review and test this patch for NSPR?  Thanks.

Comment 4

[Wan-Teh Chang]

Attachment: JSS patch

Glen, please review and test this patch for JSS.  Thanks.

Comment 5

[(not reading, please use [e-mail] instead)]

> bsmedberg:  for xul.dll, I don't see any company info at all.

spun off to bug #385496

Comment 6

[glen beasley]

Comment on attachment 269409 [details] [diff] [review]
JSS patch

 cvs commit -m "385347 CompanyName shoud be Mozilla Foundation fix=wtc r=glen" jss.rc
Enter passphrase for key '/Users/b/.ssh/id_dsa': 
Checking in jss.rc;
/cvsroot/mozilla/security/jss/lib/jss.rc,v  <--  jss.rc
new revision: 1.3; previous revision: 1.2
done

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 269405 [details] [diff] [review]
NSPR patch

r=sspitzer, sorry for the long delay Wan-Teh.

I've reviewed and tested against the firefox trunk.

Comment 8

[Wan-Teh Chang]

Comment on attachment 269405 [details] [diff] [review]
NSPR patch

Thanks.  I checked in the NSPR patch on the NSPR trunk for NSPR 4.7.

Seth, others still need to fix the js3250.dll and xul.dll issues.

Comment 10

[timeless]

Js is covered by 341901

Comment 11

[timeless]

xul is covered by 387454

Comment 12

[(not currently active) Ted Mielczarek]

I'm fixing mozcrt19.dll in bug 415918.

Comment 13

[YF (Yang)]

Currently no longer exists.