3855 - toolbar buttons don't fit in horizontal space allocated

Status: VERIFIED FIXED

(Core Graveyard :: Tracking, defect, P2)

Description

[Akkana Peck]

Sometime between Monday morning and Tuesday morning (i.e. during the M3 freeze),
someone changed the toolbar spacing so that now the stop button gets wrapped to
a second line rather than fitting with the other three toolbar buttons.

This should be considered a BLOCK M3 bug because it was fine on Monday and only
got changed during the freeze, and that change caused a regression and should be
backed out.

Comment 1

[Akkana Peck]

I notice hyatt made a lot of changes to the apprunner UI in the last day,
reassigning ...

Comment 2

[Akkana Peck]

This broke with version 1.34 of navigator.xul, when the width on line 500 was
changed from 160 to 155.  It needs to be 160 in order for the toolbar buttons to
fit on one line.

Changing it to 160 fixes the problem -- the stop button is still wrapped when
the buttons are first getting laid out, but at least it snaps to its proper
position when the window finally stabilizes.

Comment 3

[David Hyatt]

Yeah, this is an example of a lousy thing we're having to do with table layout,
since we don't have our own layout manager in place... the extra width looks a
bit silly on Mac and Windows (which use narrower fonts), but omitting the width
all together doesn't work.

Just change it back to 160.

Comment 4

[Akkana Peck]

Fix checked in.  I don't know why the toolbars are initially drawn the wrong
size; I'll file a separate bug on that (not M3).

Comment 5

[sujay]

verified in 3/19 build.

Comment 6

[leger]

Moving all Apprunner bugs past and present to Other component temporarily whilst
don and I set correct component.  Apprunner component will be deleted/retired
shortly.