385508 - Some languages aren't kept on redirects

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Wil Clouser [:clouserw]]

Attachment: add locale to redirects

Some of the redirects in the .htaccess don't keep the language, which means people might not get the language they want.  This attachment just sticks the requested locale onto the redirect.

Comment 1

[Reed Loden [:reed]]

Comment on attachment 269423 [details] [diff] [review]
add locale to redirects

>-RewriteRule ^(\w{2,3}(-\w{2}(-mac)?)/)?firefox/privacy[/]?$ legal/privacy/ [PT]
>+RewriteRule ^(\w{2,3}(-\w{2}(-mac)?)/)?firefox/privacy[/]?$ $1/legal/privacy/ [PT]

$1 should already include the '/', so you shouldn't add another one. Also, you should probably use the same regex match as what is used below [ (\w{2,3}(?:-\w{2}(?:-mac)?)?/)? ].

>-RewriteRule ^(?:\w{2,3}(?:-\w{2}(?:-mac)?)?/)?products/firefox(/.*)?$ firefox$1 [PT]
>-RewriteRule ^(?:\w{2,3}(?:-\w{2}(?:-mac)?)?/)?products/thunderbird(/.*)?$ thunderbird$1 [PT]
>+RewriteRule ^(\w{2,3}(?:-\w{2}(?:-mac)?)?/)?products/firefox(/.*)?$ $1firefox$2 [PT]
>+RewriteRule ^(\w{2,3}(?:-\w{2}(?:-mac)?)?/)?products/thunderbird(/.*)?$ $1thunderbird$2 [PT]

This is ok.

> RewriteRule ^(?:\w{2,3}(?:-\w{2}(?:-mac)?)?/)?firefox/2.0rc[1-3]/releasenotes[/]?$ firefox/2.0/releasenotes/ [PT]
> RewriteRule ^(?:\w{2,3}(?:-\w{2}(?:-mac)?)?/)?thunderbird/2.0.0.0rc[1-4]/releasenotes[/]?$ thunderbird/2.0.0.0/releasenotes/ [PT]

Why aren't you changing these?

>-RewriteRule ^firefox/livebookmarks[/]?$ firefox/livebookmarks.html [PT]
>+RewriteRule ^(?:\w{2,3}(?:-\w{2}(?:-mac)?)?/)?firefox/livebookmarks[/]?$ firefox/livebookmarks.html [PT]

I'm pretty sure this is 1.5.0.x only, but whatever.

> RewriteRule ^(?:\w{2,3}(?:-\w{2}(?:-mac)?)?/)?thunderbird/([2-9](?:\.\d){1,3})pre(/.*)$ thunderbird/$1$2 [PT]

Why aren't you changing this one?

Comment 2

[Wil Clouser [:clouserw]]

Attachment: add lang to rewrites

I'm not sure - added them to this patch.

Comment 3

[Wil Clouser [:clouserw]]

thanks, r4647