leaksoup trace-malloc reader shouldn't use NS_QuickSort

RESOLVED INACTIVE

Status

()

Core
XPCOM
RESOLVED INACTIVE
11 years ago
3 days ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({perf})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Assignee)

Description

11 years ago
The leaksoup trace-malloc reader uses NS_QuickSort to sort lists by numbers that it assigned to nodes in order (of various graph traversals).  It should instead allocate an array for both of these sorts and fill in the array as it assigns the numbers.
Whiteboard: [good first bug][mentor=dbaron][lang=c++]
/tools/trace-malloc/leaksoup.cpp
    * line 44 -- #include "nsQuickSort.h"
    * line 244 -- NS_QuickSort(sorted_nodes, count, sizeof(AllocationNode*),
    * line 319 -- NS_QuickSort(sorted_nodes, count, sizeof(AllocationNode*),

Comment 2

5 years ago
Hello, my friend and I would like to help out Mozilla, and we believe this is a good bug for us to start with. Is this bug still open? And if so, what are the first steps we should to get started.
(Assignee)

Comment 3

5 years ago
I didn't mark this as [good first bug], and I don't think it is; I think good first bugs are much more likely to be ones where the purpoe of fixing the bug is more apparent (unlike, say, fixing a performance problem in a memory leak debugging tool used by only a few developers).
Whiteboard: [good first bug][mentor=dbaron][lang=c++]

Comment 4

3 days ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: 3 days ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.