385532 - After restarting Firefox from Crash Reporter client, Breakpad doesn't catch the crash

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070621 Minefield/3.0a6pre

Steps to reproduce:
1. Set the MOZ_CRASHREPORTER env. var. to 1.
2. Go to a website that crashes Firefox.
3. Crash.
4. In the Crash Reporter client, choose "Restart Firefox".
5. Repeat steps 2 and 3.

Actual Results:
Breakpad doesn't catch the crash and Firefox doesn't shutdown.

Expected results:
Breakpad catches the crash like it did on the first time.

This could be limited to my debug build, but I filed it anyway. Will test again once we get packaged Linux build working.

Comment 1

[Jeff Walden [:Waldo]]

dcamp: might this be caused in this manner?  I haven't investigated at all.  :-)

https://bugzilla.mozilla.org/show_bug.cgi?id=345057#c5

Comment 2

[Dave Camp (:dcamp)]

Attachment: unblock signals in crashreporter

Breakpad blocks signals while executing the minidump handler.  That persists across fork/exec()s, and screws stuff up.

It's probably not a good idea to try to unblock those signals in the signal handler, so this patch does it at the very start of the crash reporting tool.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 269479 [details] [diff] [review]
unblock signals in crashreporter

Looks good, but would it be cleaner to stick this in UIInit in crashreporter_linux.cpp?

Comment 4

[Dave Camp (:dcamp)]

Attachment: patch as checked in

moved it to UIInit and checked in.