Closed Bug 385539 Opened 12 years ago Closed 12 years ago

need to move nsBidi::SymmSwap into intl/unicharutil

Categories

(Core :: Internationalization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jtd, Assigned: smontagu)

References

Details

Attachments

(2 files)

This function is needed within gfx but we don't want to put in a dependency for gfx on layout.
Blocks: 361695
Depends on: 385639
Component: General → Internationalization
Product: Firefox → Core
QA Contact: general → i18n
OS: Mac OS X → All
Hardware: PC → All
Attached patch PatchSplinter Review
Attachment #270280 - Flags: superreview?(roc)
Attachment #270280 - Flags: review?(roc)
Attachment #270280 - Flags: superreview?(roc)
Attachment #270280 - Flags: superreview+
Attachment #270280 - Flags: review?(roc)
Attachment #270280 - Flags: review+
Attached patch patch v.2Splinter Review
Added makefile change, libxul build on mac attempts to build nsBidiUtils.cpp from within the <objdir>/toolkit/library directory, so need to add headers to EXPORT list.  Quite possibly there's a better build system way to do this...
Attachment #270369 - Attachment is patch: true
Attachment #270369 - Attachment mime type: application/octet-stream → text/plain
I came across that problem also (which is why I hadn't checked in yet), and was going to solve it by addding 
LOCAL_INCLUDES += -I$(topsrcdir)/intl/unicharutil/util
in toolkit/library/Makefile.in, which I think is better.
Checked in attachment 270280 [details] [diff] [review] plus the change in comment 3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.