Closed
Bug 385539
Opened 18 years ago
Closed 18 years ago
need to move nsBidi::SymmSwap into intl/unicharutil
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
People
(Reporter: jtd, Assigned: smontagu)
References
Details
Attachments
(2 files)
|
31.21 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
31.35 KB,
patch
|
Details | Diff | Splinter Review |
This function is needed within gfx but we don't want to put in a dependency for gfx on layout.
|
||
Updated•18 years ago
|
Component: General → Internationalization
Product: Firefox → Core
QA Contact: general → i18n
|
Assignee | |
Updated•18 years ago
|
OS: Mac OS X → All
Hardware: PC → All
|
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #270280 -
Flags: superreview?(roc)
Attachment #270280 -
Flags: review?(roc)
Attachment #270280 -
Flags: superreview?(roc)
Attachment #270280 -
Flags: superreview+
Attachment #270280 -
Flags: review?(roc)
Attachment #270280 -
Flags: review+
|
Reporter | |
Comment 2•18 years ago
|
||
Added makefile change, libxul build on mac attempts to build nsBidiUtils.cpp from within the <objdir>/toolkit/library directory, so need to add headers to EXPORT list. Quite possibly there's a better build system way to do this...
|
|
Reporter | |
Updated•18 years ago
|
Attachment #270369 -
Attachment is patch: true
Attachment #270369 -
Attachment mime type: application/octet-stream → text/plain
|
|
Assignee | |
Comment 3•18 years ago
|
||
I came across that problem also (which is why I hadn't checked in yet), and was going to solve it by addding
LOCAL_INCLUDES += -I$(topsrcdir)/intl/unicharutil/util
in toolkit/library/Makefile.in, which I think is better.
|
|
Assignee | |
Comment 4•18 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•