If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

need to move nsBidi::SymmSwap into intl/unicharutil

RESOLVED FIXED

Status

()

Core
Internationalization
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: jtd, Assigned: smontagu)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
This function is needed within gfx but we don't want to put in a dependency for gfx on layout.
(Reporter)

Updated

10 years ago
Blocks: 361695
(Assignee)

Updated

10 years ago
Depends on: 385639
Component: General → Internationalization
Product: Firefox → Core
QA Contact: general → i18n
(Assignee)

Updated

10 years ago
OS: Mac OS X → All
Hardware: PC → All
(Assignee)

Comment 1

10 years ago
Created attachment 270280 [details] [diff] [review]
Patch
Attachment #270280 - Flags: superreview?(roc)
Attachment #270280 - Flags: review?(roc)
Attachment #270280 - Flags: superreview?(roc)
Attachment #270280 - Flags: superreview+
Attachment #270280 - Flags: review?(roc)
Attachment #270280 - Flags: review+
(Reporter)

Comment 2

10 years ago
Created attachment 270369 [details] [diff] [review]
patch v.2

Added makefile change, libxul build on mac attempts to build nsBidiUtils.cpp from within the <objdir>/toolkit/library directory, so need to add headers to EXPORT list.  Quite possibly there's a better build system way to do this...
(Reporter)

Updated

10 years ago
Attachment #270369 - Attachment is patch: true
Attachment #270369 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 3

10 years ago
I came across that problem also (which is why I hadn't checked in yet), and was going to solve it by addding 
LOCAL_INCLUDES += -I$(topsrcdir)/intl/unicharutil/util
in toolkit/library/Makefile.in, which I think is better.
(Assignee)

Comment 4

10 years ago
Checked in attachment 270280 [details] [diff] [review] plus the change in comment 3
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.