385545 - toolbar folder contents aren't visible some time after loading

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dietrich Ayala (:dietrich)]

maybe a regression from bug 337855?

9:56:48 AM mconnorfx: hey, I'm seeing this bug where bookmark toolbar folders stop displaying after a while
9:56:59 AM mconnorfx: like, the contents
9:57:08 AM autonomatic: the folder is there, but empty?
9:57:10 AM mconnorfx: yeah
9:57:13 AM autonomatic: and only sometimes?
9:57:20 AM mconnorfx: yeah
9:57:21 AM autonomatic: in all widgets?
9:57:26 AM mconnorfx: on a per-window basis
9:57:30 AM autonomatic: menu/org/toolbar
9:57:33 AM mconnorfx: just on the BTF
9:57:36 AM mconnorfx: menu is fine
9:57:40 AM mconnorfx: org is fine
9:57:45 AM mconnorfx: new window will work
9:57:52 AM autonomatic: hm, gotta be widget then
9:57:54 AM mconnorfx: and then eventually stop working
9:58:25 AM mconnorfx: of course, nothing in the console other than the ever-so-helpful: 
9:58:26 AM mconnorfx: Error: [Exception... "'Component does not have requested interface' when calling method: [nsIInterfaceRequestor::getInterface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "<unknown>"  data: no]
9:58:33 AM autonomatic: hm
9:58:38 AM autonomatic: is there a bug already?
9:58:41 AM mconnorfx: dunno
9:58:47 AM mconnorfx: was asking you first 
9:58:51 AM autonomatic: k, i'll look into it. on mac?
9:58:56 AM mconnorfx: yeah
10:00:41 AM mconnorfx: ok, so, in DOMI, I see no children

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070622 Minefield/3.0a6pre
The bookmarks on the Bookmarks Toolbar are totally gone. Here only missing since Bug 385524 with errors about the login manager. But that bug was checked in after this bug was reported.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Sorry for the fuss, the problem in comment 1 disappeared when Bug 385524 was backed out.

Comment 3

[Asaf Romano (gone)]

Attachment: tentative patch

This makes invalidateContainer clear dead entries from the map (which would then refer to dead dom nodes, probably leaking the world).

Hopefully this doesn't suck performance-wise.

Comment 5

[Mike Connor [:mconnor]]

We need this fixed for a6...

Comment 6

[Dietrich Ayala (:dietrich)]

Comment on attachment 269937 [details] [diff] [review]
tentative patch

so, r=me for a band-aid patch. however, this did appear to slow menus down from the subjective testing that i did. also, it's not clear what caused this to regress. please keep this open for finding out what the real problem is.

Comment 7

[Asaf Romano (gone)]

dietrich, this is not a band-aid... I do plan to optimize this later though.

Comment 8

[Asaf Romano (gone)]

mozilla/browser/components/places/content/menu.xml 1.78
mozilla/browser/components/places/content/toolbar.xml 1.95

Comment 9

[Dave Townsend [:mossop]]

I'm still hitting this in my current build (2007062804) however it's subtly different. Previously either all the toolbar folders worked or none did. Now however I spotted that just the livemark folder was broken, then a short time later all except one normal folder were broken ("Work" for my future reference).

While in this state I tried opening a bookmark from the main menu and got an assert popupup:

"Unable to find menuitem" PMV_itemChanged(nsINavHistoryResultNode)

After dismissing this it appeared again about 3/4 times before it stopped.

Comment 10

[Dave Townsend [:mossop]]

I have to say that I don't think I've seen this issue since my last comment. Maybe this has cleared up?

Comment 11

[Mike Connor [:mconnor]]

I haven't seen this either, marking FIXED for now, if someone can repro please reopen.

Comment 12

[Tracy Walker [:tracy]]

verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072505 Minefield/3.0a7pre and the equivalent Mac build. I'm not sure what PC - Mac is so making those all

in litmus - http://litmus.mozilla.org/show_test.cgi?id=3999

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv