385572 - sunbird.exe is compiled with incorrect Product Version information

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: rev0 - override product version with app version (TRUNK patch)

sunbird.exe is compiled with incorrect Product Version information

This bug is the equivalent of Firefox/Thunderbird Bug 286825 and SeaMonkey Bug 302401.

Comment 1

[Daniel Boelzle [:dbo]]

>+WIN32_MODULE_PRODUCTVERSION=0,5,9,0
>+WIN32_MODULE_PRODUCTVERSION_STRING=0.6a1
why not
>+WIN32_MODULE_PRODUCTVERSION=0,6,9,0
>+WIN32_MODULE_PRODUCTVERSION_STRING=0.7a1
?

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 269497 [details] [diff] [review]
rev0 - override product version with app version (TRUNK patch)

For clarification: this is the patch for TRUNK.

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: rev0 - override product version with app version (MOZILLA_1_8_BRANCH patch)

Same patch but for MOZILLA_1_8_BRANCH.

Comment 4

[ause]

introducing *PRODUCTVERSION* is fine. but removing *FILEVERSION* presents an ugly 0.0.0.0 as fileversion in properties/version of the binary.

Comment 5

[Stefan Sitter [:ssitter]]

(In reply to comment #4)
I disagree. I did testbuilds on Trunk and Branch and with the patch the file and product version is set the same way as in firefox.exe or thunderbird.exe.

Currently:
  File version:    0.5.0.0
  Product version: 1.8.1.4pre: 2007061404

With patch:
  File version:    1.8.20070.61404
  Product version: 0.5.0.0

Maybe you see 0.0.0.0 if you do a non-official build that doesn't create a BuildID but uses 0000000000 instead?

Comment 6

[ause]

you're right. sorry for the noise...

Comment 7

[Daniel Boelzle [:dbo]]

Patches look ok, although we need to clarify the version number on trunk. I am still a great fan to use the same name (e.g. 0.7trunk or 0.7unstable), so users aren't tempted to install the trunk build because of the higher version number.

Comment 8

[Daniel Boelzle [:dbo]]

switch to 0.7pre on branch?

Comment 9

[Stefan Sitter [:ssitter]]

Now that 0.5 is released it's makes sense to fix this bug together with bug 386195 in one patch. I can add a new patch if we decide on the new version number to use.

Comment 10

[Stefan Sitter [:ssitter]]

Comment on attachment 269497 [details] [diff] [review]
rev0 - override product version with app version (TRUNK patch)

Re-requesting review for TRUNK patch.

Comment 11

[Simon Paquet [:sipaq]]

The branch has been fixed yesterday, with the checkin for bug 386195.

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 269497 [details] [diff] [review]
rev0 - override product version with app version (TRUNK patch)

r=mvl

Comment 13

[Stefan Sitter [:ssitter]]

checkin-needed for attachment 269497 [details] [diff] [review] (TRUNK only)

Comment 14

[Daniel Boelzle [:dbo]]

Checked in on HEAD.