Closed Bug 385572 Opened 17 years ago Closed 16 years ago
.exe is compiled with incorrect Product Version information
sunbird.exe is compiled with incorrect Product Version information This bug is the equivalent of Firefox/Thunderbird Bug 286825 and SeaMonkey Bug 302401.
>+WIN32_MODULE_PRODUCTVERSION=0,5,9,0 >+WIN32_MODULE_PRODUCTVERSION_STRING=0.6a1 why not >+WIN32_MODULE_PRODUCTVERSION=0,6,9,0 >+WIN32_MODULE_PRODUCTVERSION_STRING=0.7a1 ?
Comment on attachment 269497 [details] [diff] [review] rev0 - override product version with app version (TRUNK patch) For clarification: this is the patch for TRUNK.
Attachment #269497 - Attachment description: rev0 - override product version with app version → rev0 - override product version with app version (TRUNK patch)
Same patch but for MOZILLA_1_8_BRANCH.
introducing *PRODUCTVERSION* is fine. but removing *FILEVERSION* presents an ugly 0.0.0.0 as fileversion in properties/version of the binary.
(In reply to comment #4) I disagree. I did testbuilds on Trunk and Branch and with the patch the file and product version is set the same way as in firefox.exe or thunderbird.exe. Currently: File version: 0.5.0.0 Product version: 126.96.36.199pre: 2007061404 With patch: File version: 1.8.20070.61404 Product version: 0.5.0.0 Maybe you see 0.0.0.0 if you do a non-official build that doesn't create a BuildID but uses 0000000000 instead?
you're right. sorry for the noise...
Patches look ok, although we need to clarify the version number on trunk. I am still a great fan to use the same name (e.g. 0.7trunk or 0.7unstable), so users aren't tempted to install the trunk build because of the higher version number.
switch to 0.7pre on branch?
Now that 0.5 is released it's makes sense to fix this bug together with bug 386195 in one patch. I can add a new patch if we decide on the new version number to use.
Depends on: 386195
Comment on attachment 269497 [details] [diff] [review] rev0 - override product version with app version (TRUNK patch) Re-requesting review for TRUNK patch.
The branch has been fixed yesterday, with the checkin for bug 386195.
Comment on attachment 269497 [details] [diff] [review] rev0 - override product version with app version (TRUNK patch) r=mvl
Attachment #269497 - Flags: review?(mvl) → review+
Checked in on HEAD.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.7
You need to log in before you can comment on or make changes to this bug.