Closed
Bug 385572
Opened 18 years ago
Closed 18 years ago
sunbird.exe is compiled with incorrect Product Version information
Categories
(Calendar :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
0.7
People
(Reporter: ssitter, Assigned: ssitter)
References
Details
Attachments
(1 file, 1 obsolete file)
879 bytes,
patch
|
mvl
:
review+
|
Details | Diff | Splinter Review |
sunbird.exe is compiled with incorrect Product Version information
This bug is the equivalent of Firefox/Thunderbird Bug 286825 and SeaMonkey Bug 302401.
Attachment #269497 -
Flags: review?(daniel.boelzle)
Comment 1•18 years ago
|
||
>+WIN32_MODULE_PRODUCTVERSION=0,5,9,0
>+WIN32_MODULE_PRODUCTVERSION_STRING=0.6a1
why not
>+WIN32_MODULE_PRODUCTVERSION=0,6,9,0
>+WIN32_MODULE_PRODUCTVERSION_STRING=0.7a1
?
Assignee | ||
Comment 2•18 years ago
|
||
Comment on attachment 269497 [details] [diff] [review]
rev0 - override product version with app version (TRUNK patch)
For clarification: this is the patch for TRUNK.
Attachment #269497 -
Attachment description: rev0 - override product version with app version → rev0 - override product version with app version (TRUNK patch)
Assignee | ||
Comment 3•18 years ago
|
||
Same patch but for MOZILLA_1_8_BRANCH.
Attachment #269693 -
Flags: review?(daniel.boelzle)
introducing *PRODUCTVERSION* is fine. but removing *FILEVERSION* presents an ugly 0.0.0.0 as fileversion in properties/version of the binary.
Assignee | ||
Comment 5•18 years ago
|
||
(In reply to comment #4)
I disagree. I did testbuilds on Trunk and Branch and with the patch the file and product version is set the same way as in firefox.exe or thunderbird.exe.
Currently:
File version: 0.5.0.0
Product version: 1.8.1.4pre: 2007061404
With patch:
File version: 1.8.20070.61404
Product version: 0.5.0.0
Maybe you see 0.0.0.0 if you do a non-official build that doesn't create a BuildID but uses 0000000000 instead?
Comment 7•18 years ago
|
||
Patches look ok, although we need to clarify the version number on trunk. I am still a great fan to use the same name (e.g. 0.7trunk or 0.7unstable), so users aren't tempted to install the trunk build because of the higher version number.
Flags: blocking-calendar0.7+
Comment 8•18 years ago
|
||
switch to 0.7pre on branch?
Assignee | ||
Comment 9•18 years ago
|
||
Now that 0.5 is released it's makes sense to fix this bug together with bug 386195 in one patch. I can add a new patch if we decide on the new version number to use.
Depends on: 386195
Assignee | ||
Updated•18 years ago
|
Attachment #269497 -
Attachment is obsolete: true
Attachment #269497 -
Flags: review?(daniel.boelzle)
Assignee | ||
Updated•18 years ago
|
Attachment #269693 -
Attachment is obsolete: true
Attachment #269693 -
Flags: review?(daniel.boelzle)
Assignee | ||
Comment 10•18 years ago
|
||
Comment on attachment 269497 [details] [diff] [review]
rev0 - override product version with app version (TRUNK patch)
Re-requesting review for TRUNK patch.
Attachment #269497 -
Attachment is obsolete: false
Attachment #269497 -
Flags: review?(mvl)
Comment 11•18 years ago
|
||
The branch has been fixed yesterday, with the checkin for bug 386195.
Comment 12•18 years ago
|
||
Comment on attachment 269497 [details] [diff] [review]
rev0 - override product version with app version (TRUNK patch)
r=mvl
Attachment #269497 -
Flags: review?(mvl) → review+
Assignee | ||
Comment 13•18 years ago
|
||
checkin-needed for attachment 269497 [details] [diff] [review] (TRUNK only)
Keywords: checkin-needed
Comment 14•18 years ago
|
||
Checked in on HEAD.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 0.7
You need to log in
before you can comment on or make changes to this bug.
Description
•