Closed Bug 385577 Opened 13 years ago Closed 13 years ago

Remove non-cairo PostScript support

Categories

(Core Graveyard :: GFX, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: mats, Assigned: mats)

References

Details

Attachments

(1 file)

Attached patch Patch rev. 1Splinter Review
In addition to the changes in the patch: cvs rm gfx/src/ps/*
Attachment #269505 - Flags: superreview?(pavlov)
Attachment #269505 - Flags: review?(pavlov)
Comment on attachment 269505 [details] [diff] [review]
Patch rev. 1

looks OK to me.  kherron should take a look at this as well.
Attachment #269505 - Flags: superreview?(pavlov)
Attachment #269505 - Flags: superreview+
Attachment #269505 - Flags: review?(pavlov)
Attachment #269505 - Flags: review?(kherron+mozilla)
Comment on attachment 269505 [details] [diff] [review]
Patch rev. 1

This looks fine. I guess it's too early to remove the enable-postscript flag from configure; it looks like it's still used to control building the psshared directory.

There are some prefs in modules/libpref/src/init/all.js that should also be removed. They all start with "print.postscript.nativefont".
Attachment #269505 - Flags: review?(kherron+mozilla) → review+
(In reply to comment #2)
> There are some prefs in modules/libpref/src/init/all.js that should also be
> removed. They all start with "print.postscript.nativefont".

Good catch, thanks.
Checked in to trunk at 2007-07-05 04:29 PDT.

-> FIXED
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta1
What's still using the code in psshared?  Do we really still need it, and the --enable-postscript flag?
dbaron: See bug 383159 for some discussion on psshared.
Flags: in-testsuite-
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.