Closed Bug 385611 Opened 12 years ago Closed 12 years ago
.jsm isn't packaged
Seems like https://bugzilla.mozilla.org/show_bug.cgi?id=380970#c30 never happened, so this adds XPCOMUtils.jsm to the necessary install manifests.
Attachment #269552 - Flags: review?(sayrer)
Comment on attachment 269552 [details] [diff] [review] Patch looks like backslashes in the unix package
Attachment #269552 - Flags: review?(sayrer) → review-
Comment on attachment 269555 [details] [diff] [review] Patch v2 why does this only add to suite on windows?
(In reply to comment #3) > (From update of attachment 269555 [details] [diff] [review]) > why does this only add to suite on windows? > It's already in the suite's *nix package.
Mea culpa on this. Wouldn't it be better, though, to say bin/modules/*, so that all the modules get picked up? What about Thunderbird?
(In reply to comment #5) > Mea culpa on this. > Not a problem :) > Wouldn't it be better, though, to say bin/modules/*, so that all the modules > get picked up? I figured we'd want to be selective if modules/ ever picks up some extra baggage we don't want to ship, but I guess we can cross that bridge if and when we get to it. > What about Thunderbird? And Sunbird too (we really need a better way to do this). I'll get a new patch cut shortly.
Due to the dist/bin/modules change, it would be unwise to roll out 1.9a6 without this bug being fixed.
mozilla/suite/installer/windows/packages 1.14 mozilla/browser/installer/unix/packages-static 1.111 mozilla/browser/installer/windows/packages-static 1.123 mozilla/calendar/installer/windows/packages-static 1.37 mozilla/mail/installer/windows/packages-static 1.57
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Ryan, thanks for also providing a patch for Sunbird. It would be really appreciated though, if you could CC one major Calendar hacker, if you touch Calendar code in a tree-wide change so that this doesn't come as a surprise to our hackers. CC'ing our lead developer, Daniel Boelzle, as a result.
This is used enough places now that if it's not included, things will break rather visibly, so no need for any tests, really.
You need to log in before you can comment on or make changes to this bug.