385616 - Hard to dismiss a menulist opened within a panel

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Asaf Romano (gone)]

If a menu-list is opened from within a <panel>, clicking outside of it (but still within the panel) doesn't dismiss the menu-list. Clicking outside the panel closes the menu-list rather than closing both popups.

Comment 1

[Neil Deakin]

Works for me on Mac. Windows only perhaps?

Clicking outside the menulist should close only the menulist.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

roc and I aren't the right people to triage the blocking1.9? flag here.  Not sure how to fix that...

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is this a regression?

Neil, what's your opinion on whether this should be a blocker?

Comment 4

[Neil Deakin]

Attachment: fix up

When the panel is clicked, the menu should be rolled up. Don't include the panel in the submenu list of popups that don't cause a rollup.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 275625 [details] [diff] [review]
fix up

Sure.

Comment 6

[Martijn Wargers (dead)]

Steps to reproduce I got from Neil via irc:
1. click star icon on address bar. 
2. open the menulist. 
3.click the bookmarks panel. The menulist should close but the panel should stay open

This regressed between 2007-09-18 and 2007-09-19:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-09-18+04&maxdate=2007-09-19+09&cvsroot=%2Fcvsroot
I guess a regression from bug 392652?
(note that I'm seeing some other, incorrect behavior in those older builds, namely that the window loses focus after step 3)