Closed Bug 385677 Opened 13 years ago Closed 12 years ago

Breakpad code fails to build using GCC-4.3 snapshot

Categories

(Toolkit :: Crash Reporting, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9beta5

People

(Reporter: ahaas, Assigned: benjamin)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070620 SeaMonkey/2.0a1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070620 SeaMonkey/2.0a1pre

Hi.

The development GCC-4.3 compiler implicitly includes many fewer header files than previous GCC versions, so code that builds under GCC-4.2 or earlier may not build. The new airbag code utilizes various system functions and constants without explicitly included in the necessary files, so while the files compile in older GCC releases building with GCC-4.3 fails. In addition to missing several necessary '#include' statements, the airbag code also has an extra semi-colon character in the code which GCC-4.3 rejects when the '-pedantic' flag is used.

Reproducible: Always

Steps to Reproduce:
1. Install GCC-4.3 snapshot
2. Configure a SeaMonkey build.
3. Start build and watch the fun.
Actual Results:  
Build fails.

Expected Results:  
Build succeeds.

I'll submit a patch adding the necessary header file '#include' statements once this bug report is complete. The code then compile, _however_, there are linkage issues with the new airbag code when building with GCC-4.2 or newer that still need to be resolved.
This patch fixes the compilation problems with GCC-4.3. The next challenge is to resolve the linking errors so that new airbag code works.
Attachment #269596 - Attachment mime type: text/x-patch → text/plain
Please file this upstream at http://code.google.com/p/google-breakpad/issues/list and submit a patch there against Breakpad SVN.

We don't take patches to Breakpad code in Mozilla CVS, we require that all patches be landed upstream.
Summary: Airbag code fails to build using GCC-4.3 snapshot → Breakpad code fails to build using GCC-4.3 snapshot
Component: Build Config → Breakpad Integration
Product: Mozilla Application Suite → Toolkit
QA Contact: build-config → breakpad.integration
INVALID per comment 2. Please do file this upstream with Breakpad.
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
We have a new breakpad snapshot, and there are a couple patches we still need to take here.
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
Assignee: nobody → benjamin
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #269596 - Attachment is obsolete: true
Attachment #310013 - Flags: review?(ted.mielczarek)
Comment on attachment 310013 [details] [diff] [review]
Add system-headers and fix one include in non-google-breakpad code, rev. 1

r+a=me
Attachment #310013 - Flags: review?(ted.mielczarek)
Attachment #310013 - Flags: review+
Attachment #310013 - Flags: approval1.9+
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 13 years ago12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta5
You need to log in before you can comment on or make changes to this bug.