Closed
Bug 385716
Opened 17 years ago
Closed 17 years ago
inIFlasher.drawElementOutline and inIFlasher.repaintElement aren't null safe [@ inLayoutUtils::GetWindowFor]
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: timeless, Assigned: timeless)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
|
1.37 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
i was trying to use it from js and accidentally passed null. firefox!inLayoutUtils::GetWindowFor(class nsIDOMNode * aNode = 0x00000000)+0x14 [e:\builds\tinderbox\fx-trunk\winnt_5.2_depend\mozilla\layout\inspector\src\inlayoututils.cpp @ 60] firefox!inFlasher::DrawElementOutline(class nsIDOMElement * aElement = 0x00000000)+0xf [e:\builds\tinderbox\fx-trunk\winnt_5.2_depend\mozilla\layout\inspector\src\inflasher.cpp @ 152] xpcom_core!NS_InvokeByIndex_P(class nsISupports * that = 0x01908a78, unsigned int methodIndex = 9, unsigned int paramCount = 1, struct nsXPTCVariant * params = 0x0012d340)+0x27
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #269808 -
Flags: superreview?(bzbarsky)
Attachment #269808 -
Flags: review?(bzbarsky)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 269808 [details] [diff] [review] ensure arg pointer Sure
Attachment #269808 -
Flags: superreview?(bzbarsky)
Attachment #269808 -
Flags: superreview+
Attachment #269808 -
Flags: review?(bzbarsky)
Attachment #269808 -
Flags: review+
Comment on attachment 269808 [details] [diff] [review] ensure arg pointer mozilla/layout/inspector/src/inFlasher.cpp 1.35
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite?
Target Milestone: --- → mozilla1.9beta1
|
||
Updated•13 years ago
|
Crash Signature: [@ inLayoutUtils::GetWindowFor]
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•