38576 - commonDialog.js dialog is too wide for screen

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect, P3)

Description

[locka]

I clicked on the submit button in a form (see sample URL) and I was presented 
with the dialog "Any information you submit is insecure and could be observed by 
a third party ... " etc. that appears every time you do this unless you uncheck 
the "Show Me This Alert Next Time". Unfortunately, the message is so long that 
the dialog stretches to the display width and still does not show the whole 
message.

The dialog should be a sensible size and wrap the message to fit if it is too 
long to display on one line.

Comment 1

[John Morrison]

*** Bug 38584 has been marked as a duplicate of this bug. ***

Comment 2

[Peter "jag" Annema]

*** Bug 38804 has been marked as a duplicate of this bug. ***

Comment 3

[Peter Trudelle]

This looks like DougT's, reassigning.

Comment 4

[Doug Turner (:dougt)]

Peter, the problem is that the Alert and Confirm dialogs do a poor job at 
wrapping text.  I am not sure who owns this.  Back to you.

Comment 5

[John Morrison]

I think this 'too wide alert' comes from the code in commonDialog.js, where 
the message text is put inside a <text> element. These elements do not wrap
by definition (no?). I'm not sure what the right fix for this is though. alecf?

Comment 6

[Alec Flett]

I think this is a bug with boxes, because new children to vertically-oriented
boxes are being added to the box as if the box is horizontally aligned.
Adding evaughan, box owner

Comment 7

[John Morrison]

I cheated and spoke with eric earlier. Try a change like this to 
commonDialog.js (not that it makes the dialog pretty, but line-wrapping
is restored/width is reasonable)

> diff -c commonDialog.js.orig commonDialog.js
*** commonDialog.js.orig        Thu May 11 19:45:32 2000
--- commonDialog.js     Thu May 11 19:45:41 2000
***************
*** 60,68 ****
                done = true;
                messageFragment = messageText;
              }
!           var textnode = document.createElement("text");
!           textnode.setAttribute("value", messageFragment);
!           messageParent.appendChild(textnode);
            }
        }
        var msg = param.GetString( 3 );
--- 60,69 ----
                done = true;
                messageFragment = messageText;
              }
!           var textnode = document.createTextNode(messageFragment);
!           var htmlnode = document.createElement("html");
!           htmlnode.appendChild(textnode);
!           messageParent.appendChild(htmlnode);
            }
        }
        var msg = param.GetString( 3 );

Comment 8

[Alec Flett]

ok.... but what did eric say about adding elements to the box? should we file a
new bug?

Comment 9

[John Morrison]

Sorry, I wasn't clear. I spoke with Eric earlier this afternoon, before your 
note above. I didn't ask him about your 'box children orientation' question.
Yes, file a bug (although did this just start happening since this morning?
I don't see it in a quick test with an a.m. build). 

Do you want to take this bug, by the way?

Comment 10

[Alec Flett]

do you mind just checking in your patch for now? looks good to me.

Comment 11

[John Morrison]

Ah, but I just a plebe with no checkin powers or know-how :-] Over to you ...

Comment 12

[Jesse Ruderman]

what's the point of this alert?  sites can gather information without using 
submittable forms, and many sites with forms do not gather information.

Comment 13

[John Morrison]

Jesse : that's a topic for a newsgroup or a separate bug report. This issue
really boils down to a generic bit of dialog behaviour. [Although, personally
I feel that this warning is instructive and appropriate].

Comment 14

[Alec Flett]

oh! I'll check in your patch.

Comment 15

[Alec Flett]

fix checked in, thanks john

Comment 16

[Keyser Sose]

Works for Me
Platform: PC
OS: Windows 98
Build # 2000100508

Marking as Verified