Closed
Bug 385818
Opened 19 years ago
Closed 18 years ago
Uninitialized promptService variable
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 3 beta1
People
(Reporter: sylvain.pasche, Assigned: sylvain.pasche)
Details
Attachments
(1 file)
|
2.12 KB,
patch
|
Gavin
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
I saw this by accident. I guess it would fail (I did not test yet):
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/preferences/security.js&rev=1.11&mark=426-428#426
|
||
Comment 1•18 years ago
|
||
Yeah, it fails.
Also, seems like if the alert is saying "you can't do this in FIPS mode", then it should recheck the checkbox (or just set it to be disabled in the first place).
|
|
||
Comment 2•18 years ago
|
||
(oh, maybe that's normally taken care of by the initMasterPasswordUI() call below the failure)
|
||
Comment 3•18 years ago
|
||
Sylvain: can you attach a patch?
|
Assignee | |
Comment 4•18 years ago
|
||
I also fixed some getService indentations in other places
Attachment #284843 -
Flags: review?(gavin.sharp)
|
|
||
Comment 5•18 years ago
|
||
Comment on attachment 284843 [details] [diff] [review]
set promptService
Thanks!
Attachment #284843 -
Flags: review?(gavin.sharp)
Attachment #284843 -
Flags: review+
Attachment #284843 -
Flags: approval1.9?
|
||
Updated•18 years ago
|
Attachment #284843 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•18 years ago
|
Assignee: nobody → sylvain.pasche
Keywords: checkin-needed
|
||
Comment 6•18 years ago
|
||
Checking in browser/components/preferences/security.js;
/cvsroot/mozilla/browser/components/preferences/security.js,v <-- security.js
new revision: 1.14; previous revision: 1.13
done
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
You need to log in
before you can comment on or make changes to this bug.
Description
•