385837 - No window gets the focus when loading a URL from an external application.

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

I tested on OS X and Vista, here are the steps to reproduce

1.  Open minefield, and another window (download manager, add-ons manager)
2.  Give another application the focus
3.  Open a URL from an external app (shortcut to a web page, URL in a RSS reader, etc.)

Minefield will load the page, but none of the minefield windows will have the focus.  On OS X the last window to have the focus (like the download manager, or add-ons manager) will get the focus back, instead of focus going to the browser window loading the page.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Is this a regression?

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

>Is this a regression?

This is a regression from Firefox 2, but I'm not sure when it occurred.

Comment 3

[Boris Zbarsky [:bzbarsky]]

I suspect this is a front-end issue (since the front end is what knows that a load came from an external app, and would thus have to do the focusing desired here).  But please do reassign back to docshell if there is evidence that this is a docshell problem.

Comment 5

[Tim Riley [:timr]]

Marcia-  can you look at this one and resolve the qawanted?  They are looking for a regression range.

Comment 6

[Dave Townsend [:mossop]]

Attachment: patch rev 1

It looks like whatever changed simply stopped us automatically focusing new tabs on opens in background windows, which I think is the right thing anyway.

This patch just focuses the new tab if it is not a background open. This brings us to the same behaviour as Bon Echo.

There is still an issue with background loads where the app still receives focus on OSX, but that also occurs on Bon Echo and I suspect is a widget related issue or something.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Any chance we could get a regression range for this?

Comment 8

[Dave Townsend [:mossop]]

Attachment: patch rev 2

This is a regression from bug 348369 however to keep that fixed we should only focus the window if the load was external.

Comment 9

[Dave Townsend [:mossop]]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.873; previous revision: 1.872
done

Comment 10

[Marcia Knous [:marcia]]

verified fixed using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a9pre) Gecko/2007102404 Minefield/3.0a9pre and Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007102407 Minefield/3.0a9pre. I verified by following the STR in the initial report and launching a link from Thunderbird.