385849 - Make Bugzilla::Bug do updating for op_sys, rep_platform, and other product-inspecific fields

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

Now that we've handled most of the tables external to the "bugs" table (cc, keywords, dependencies), it's time to start work on the actual bugs table itself.

The easiest things to move should be op_sys, rep_platform, etc. But not resolution or bug_status--those are complex and they'll come later.

Comment 1

[Max Kanat-Alexander]

Attachment: WIP

Here's what I have so far. I like it pretty well. Just need to implement the actual updating and then do some testing.

Comment 2

[Max Kanat-Alexander]

Might as well do status_whiteboard and short_desc while we're at it.

Comment 3

[Max Kanat-Alexander]

Attachment: v1

Okay, here we go! Tested and works.

Comment 4

[Frédéric Buclin]

Comment on attachment 271602 [details] [diff] [review]
v1

>Index: Bugzilla/Bug.pm

>+# To run check_can_change_field.
>+sub _set_global_validator {

Do you realize you are currently calling check_can_change_field() twice per field? Once in process_bug.cgi and once again here.


>+    my $privs;
>+    $self->check_can_change_field($field, $current_value, $value, $privs)

You have to pass $privs by reference to get the returned value.


I still have to test your patch before granting review.

Comment 5

[Max Kanat-Alexander]

(In reply to comment #4)
> Do you realize you are currently calling check_can_change_field() twice per
> field? Once in process_bug.cgi and once again here.

  Yes, I do realize. Eventually we'll make it only happen once, when everything is moved out of process_bug and into Bugzilla::Bug. (This will be before 3.2.) In the mean time, it doesn't cause any actual performance problem, it's just messy.

> You have to pass $privs by reference to get the returned value.

  Oh, thanks!

Comment 6

[Frédéric Buclin]

Comment on attachment 271602 [details] [diff] [review]
v1

>Index: Bugzilla/Bug.pm

>+sub _set_global_validator {

>+    $self->check_can_change_field($field, $current_value, $value, $privs)

Do not forget to write \$privs when committing your patch. r=LpSolit

Comment 7

[Max Kanat-Alexander]

Okay, I fixed the $privs thing. :-)

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.374; previous revision: 1.373
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.188; previous revision: 1.187
done
Checking in Bugzilla/Object.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Object.pm,v  <--  Object.pm
new revision: 1.16; previous revision: 1.15
done